-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted arrays to short syntax #243
Conversation
Confirmed. Doctrine/ORM 2.5 (required by master Kdyby/Doctrine) indeed requires PHP >=5.4. Good to merge (although commits like this are very bad for git blame). |
@enumag You are right, but this repo already have mixed long and short array syntax and it makes me furious when I want to create pull. |
@foxycode Me too. Welcome to the club. :-) |
I wanned to keep the compatibility with 5.3 as long as possible, but since doctrine/orm dropped it, there is no point in it anymore :) |
@foxycode can you please also add to .travis.yml the |
@fprochazka Done. I also added Please, tell me. Why is php7 in allowed failures? I'd like to change that. |
👍 Looks great! |
Converted arrays to short syntax
Thank you!
Nobody just got to changing it since PHP7 stabilized :)
what do you mean? |
@fprochazka Thanks for php7 :) I already using it in production with Doctrine.
As @TomasVotruba said. I'd like to know for what is |
@foxycode it fixes nette dependencies for different versions of nette |
Since doctrine/orm already supports php >=5.4, there is no need to keep old array syntax.