Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted arrays to short syntax #243

Merged
merged 1 commit into from
Mar 8, 2016
Merged

Converted arrays to short syntax #243

merged 1 commit into from
Mar 8, 2016

Conversation

foxycode
Copy link
Contributor

@foxycode foxycode commented Mar 7, 2016

Since doctrine/orm already supports php >=5.4, there is no need to keep old array syntax.

@enumag
Copy link
Member

enumag commented Mar 7, 2016

Confirmed. Doctrine/ORM 2.5 (required by master Kdyby/Doctrine) indeed requires PHP >=5.4. Good to merge (although commits like this are very bad for git blame).

@foxycode
Copy link
Contributor Author

foxycode commented Mar 7, 2016

@enumag You are right, but this repo already have mixed long and short array syntax and it makes me furious when I want to create pull.

@enumag
Copy link
Member

enumag commented Mar 7, 2016

@foxycode Me too. Welcome to the club. :-)

@fprochazka
Copy link
Member

I wanned to keep the compatibility with 5.3 as long as possible, but since doctrine/orm dropped it, there is no point in it anymore :)

@fprochazka
Copy link
Member

@foxycode can you please also add to .travis.yml the --short-arrays option, which code-checker supports?

@foxycode
Copy link
Contributor Author

foxycode commented Mar 8, 2016

@fprochazka Done. I also added "php": ">=5.4" to composer.json. Hope it's ok.

Please, tell me. Why is php7 in allowed failures? I'd like to change that.
Why you downloading own composer in travis? What is different in it?

@foxycode foxycode mentioned this pull request Mar 8, 2016
31 tasks
@TomasVotruba
Copy link
Contributor

👍 Looks great!

fprochazka added a commit that referenced this pull request Mar 8, 2016
Converted arrays to short syntax
@fprochazka fprochazka merged commit ead79c6 into Kdyby:master Mar 8, 2016
@fprochazka
Copy link
Member

Thank you!

Please, tell me. Why is php7 in allowed failures? I'd like to change that.

Nobody just got to changing it since PHP7 stabilized :)

Why you downloading own composer in travis? What is different in it?

what do you mean?

@fprochazka
Copy link
Member

@foxycode 33d1bc3 :)

@TomasVotruba
Copy link
Contributor

@foxycode Probably these lines:

Doctrine/.travis.yml

Lines 25 to 26 in 33d1bc3

- wget -O vendor/bin/composer-nette https://raw.githubusercontent.com/Kdyby/TesterExtras/master/bin/composer-nette.php
- php vendor/bin/composer-nette

@foxycode
Copy link
Contributor Author

foxycode commented Mar 8, 2016

@fprochazka Thanks for php7 :) I already using it in production with Doctrine.

Why you downloading own composer in travis? What is different in it?

As @TomasVotruba said. I'd like to know for what is composer-nette from Kdyby/TesterExtras good for.

@fprochazka
Copy link
Member

@foxycode it fixes nette dependencies for different versions of nette

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants