Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] log aop 내용 추가 #305

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

linglong67
Copy link
Collaborator

💡 Motivation and Context

log aop 내용 추가


🔨 Modified

log aop 내용 추가

  • controller 실행 시간 기록 (단, API 응답 성공한 경우 실행시간이 로그에 남습니다)
  • ##### @API Execution Time ##### [150ms] → com.kernel360.washzonereview.controller.WashzoneReviewController.getWashzoneReviewsByWashzone

🌟 More

  • ...


📋 커밋 전 체크리스트

  • 추가/변경에 대한 단위 테스트를 완료하였습니다.
  • 컨벤션에 맞게 작성하였습니다.

🤟🏻 PR로 완료된 이슈

closes #

- controller 실행 시간 기록
@linglong67 linglong67 added 🖥️ BackEnd 서버 관련 💡 Feature 새로운 기능 추가, 혹은 구현 labels Mar 15, 2024
@linglong67 linglong67 self-assigned this Mar 15, 2024
Copy link
Collaborator

@chan99k chan99k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -21,4 +23,21 @@ public Object logExecutionTime(ProceedingJoinPoint joinPoint) throws Throwable {

return proceed;
}

@Pointcut("within(*..*Controller)")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"within(*..*Controller)" 이게 어떤 역할을 하는 건가요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

범위를 정해주는 거에요~!
위에 내용으로는 ...Controller인 파일을 모두 대상으로 하는 거구요

@linglong67 linglong67 merged commit 770223c into Kernel360:develop Mar 15, 2024
@linglong67 linglong67 deleted the feature/modify-log-aspect branch March 15, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥️ BackEnd 서버 관련 💡 Feature 새로운 기능 추가, 혹은 구현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants