Don't error when no type is available #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlin-eldoc--raw-type can return nil, but merlin-eldoc--format-type only supports strings. This was fixed for merlin-eldoc--type in 3af7032, but the same issue existed in merlin-eldoc--verbose-type.
Wilfred
added a commit
to Wilfred/.emacs.d
that referenced
this pull request
Jun 30, 2018
merlin-eldoc has been patched with: Khady/merlin-eldoc#26
|
Thank you. I don't have a computer for the next two weeks. But will check and merge after.
… On 29 Jun 2018, at 23:51, Wilfred Hughes ***@***.***> wrote:
merlin-eldoc--raw-type can return nil, but merlin-eldoc--format-type
only supports strings. This was fixed for merlin-eldoc--type in
3af7032, but the same issue existed in merlin-eldoc--verbose-type.
You can view, comment on, or merge this pull request online at:
#26
Commit Summary
Don't error when no type is available
File Changes
M merlin-eldoc.el (2)
Patch Links:
https://github.com/Khady/merlin-eldoc/pull/26.patch
https://github.com/Khady/merlin-eldoc/pull/26.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Actually I have access to github so I can do the merge now. Thanks! |
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merlin-eldoc--raw-type can return nil, but merlin-eldoc--format-type
only supports strings. This was fixed for merlin-eldoc--type in
3af7032, but the same issue existed in merlin-eldoc--verbose-type.