This repository has been archived by the owner on May 11, 2021. It is now read-only.
Graphing inequalities 2 without choosing an answer #161538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validator function now returns an empty string if the user does not modify the graph or select a radio.
|
Thank you for poking at this! Unfortunately I don't think this is ready to merge in yet since it doesn't fix the issue you're seeing, but if you're able to figure out how to get KE to say "invalid answer" (I'm not sure how to do that personally) or otherwise resolve the issue I'll be happy to merge this in. I'm going to close this, but definitely open up another PR if/when you're able to finish this up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a bit of zoom the point choice below the graph is not visible, thus it's easy to click through leaving the default "Yes" selected (be it right or wrong).
Removing the default checked state and making the validator function return an empty string when it should seems to be a good start. The exercise still gets marked wrong though, so I guess the empty string return is not functional at the moment. Further, it would be nice to be able to show an orange frame surrounding the choices if the user does not select anything.