Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interactive Graph] Remove the start-coords-ui flags #1609

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

nishasy
Copy link
Contributor

@nishasy nishasy commented Sep 10, 2024

Summary:

Now that start coords UI for all graph types have been
safely out for a while now, we can remove the start-coords-ui-*
flags from Perseus.

Next, we can remove them from webapp and Growthbook.

Issue: https://khanacademy.atlassian.net/browse/LEMS-2228

Test plan:

yarn jest
yarn typecheck

  • The the perseus repo in your IDE, seach for all instances of start-coords-ui and confirm there are none left.
  • Confirm there are also no instances of TODO(LEMS-2228) left.

Storybook

Now that locked functions have been safely out for a while now, we can
remove the `interactive-graph-locked-features-m2b` flag from Perseus.

Next, we can remove it from webapp Growthbook.

Issue: https://khanacademy.atlassian.net/browse/LEMS-2107

Test plan:
`yarn jest`
`yarn typecheck`

Storybook
- http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--mafs-with-locked-figures-current
- Confirm that the locked functions are still available in the graph and editor
Now that start coords UI for all graph types have been
safely out for a while now, we can remove the `start-coords-ui-*`
flags from Perseus.

Next, we can remove them from webapp and Growthbook.

Issue: https://khanacademy.atlassian.net/browse/LEMS-2228

Test plan:
`yarn jest`
`yarn typecheck`

- The the perseus repo in your IDE, seach for all instances of `start-coords-ui` and confirm there are none left.
- Confirm there are also no instances of `TODO(LEMS-2228)` left.

Storybook
- Go to http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--interactive-graph-segment (as well as all the other graphs' stories)
- Confirm that the start coords UI show up
- Confirm that the start coords UI does not show up for unlimited points, unlimited polygons, or polygons with snapTo angles or sides
@nishasy nishasy self-assigned this Sep 10, 2024
@nishasy nishasy requested review from mark-fitzgerald and a team September 10, 2024 21:31
Copy link
Contributor

github-actions bot commented Sep 10, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (8e44460) and published it to npm. You
can install it using the tag PR1609.

Example:

yarn add @khanacademy/perseus@PR1609

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1609

Copy link
Contributor

github-actions bot commented Sep 10, 2024

Size Change: -365 B (-0.04%)

Total Size: 860 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 277 kB -365 B (-0.13%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.3 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/index.js 417 kB
packages/perseus/dist/es/strings.js 3.36 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

@nishasy nishasy marked this pull request as ready for review September 10, 2024 21:33
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Sep 10, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/bright-hairs-jog.md, packages/perseus/src/types.ts, packages/perseus-editor/src/__stories__/flags-for-api-options.ts, packages/perseus-editor/src/components/util.ts, packages/perseus-editor/src/widgets/__tests__/interactive-graph-editor.test.tsx, packages/perseus-editor/src/widgets/interactive-graph-editor/interactive-graph-editor.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.45%. Comparing base (737fe30) to head (8e44460).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1609      +/-   ##
==========================================
- Coverage   70.49%   70.45%   -0.05%     
==========================================
  Files         548      573      +25     
  Lines      107300   111730    +4430     
  Branches     7828    11845    +4017     
==========================================
+ Hits        75639    78714    +3075     
- Misses      31545    33016    +1471     
+ Partials      116        0     -116     

Impacted file tree graph

see 1121 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 737fe30...8e44460. Read the comment docs.

@nishasy nishasy changed the base branch from flag-cleanup to main September 10, 2024 23:35
@nishasy nishasy merged commit 9810472 into main Sep 10, 2024
12 of 13 checks passed
SonicScrewdriver added a commit that referenced this pull request Sep 11, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @khanacademy/perseus@33.1.0

### Minor Changes

- [#1452](#1452)
[`3980a36fa`](3980a36)
Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! -
Implementation of SVG-based Axis Tick Labels for Interactive Graph

### Patch Changes

- [#1609](#1609)
[`981047211`](9810472)
Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph]
Remove the start-coords-ui flags


- [#1610](#1610)
[`e9b317ca0`](e9b317c)
Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph
Editor] Remove the start coords UI if the graph is static


- [#1608](#1608)
[`737fe30b4`](737fe30)
Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph]
Remove the interactive-graph-locked-feature-m2b flag

## @khanacademy/perseus-editor@14.1.1

### Patch Changes

- [#1609](#1609)
[`981047211`](9810472)
Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph]
Remove the start-coords-ui flags


- [#1607](#1607)
[`1b340b197`](1b340b1)
Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph
Editor] Use Wonder Blocks TextArea in the graph description settings UI


- [#1610](#1610)
[`e9b317ca0`](e9b317c)
Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph
Editor] Remove the start coords UI if the graph is static


- [#1608](#1608)
[`737fe30b4`](737fe30)
Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph]
Remove the interactive-graph-locked-feature-m2b flag

- Updated dependencies
\[[`981047211`](9810472),
[`e9b317ca0`](e9b317c),
[`737fe30b4`](737fe30),
[`3980a36fa`](3980a36)]:
    -   @khanacademy/perseus@33.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants