-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Interactive Graph Editor] Remove the start coords UI if the graph is static #1610
Conversation
Now that locked functions have been safely out for a while now, we can remove the `interactive-graph-locked-features-m2b` flag from Perseus. Next, we can remove it from webapp Growthbook. Issue: https://khanacademy.atlassian.net/browse/LEMS-2107 Test plan: `yarn jest` `yarn typecheck` Storybook - http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--mafs-with-locked-figures-current - Confirm that the locked functions are still available in the graph and editor
Now that start coords UI for all graph types have been safely out for a while now, we can remove the `start-coords-ui-*` flags from Perseus. Next, we can remove them from webapp and Growthbook. Issue: https://khanacademy.atlassian.net/browse/LEMS-2228 Test plan: `yarn jest` `yarn typecheck` - The the perseus repo in your IDE, seach for all instances of `start-coords-ui` and confirm there are none left. - Confirm there are also no instances of `TODO(LEMS-2228)` left. Storybook - Go to http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--interactive-graph-segment (as well as all the other graphs' stories) - Confirm that the start coords UI show up - Confirm that the start coords UI does not show up for unlimited points, unlimited polygons, or polygons with snapTo angles or sides
… static When the graph is static, it uses the "correct" graph's coords to set the coords on the now noninteractive graph. This makes the start coords UI useless, as those coords will not be used. - Remove the start coords UI if the graph is static Issue: https://khanacademy.atlassian.net/browse/LEMS-2318 Test plan: `yarn jest packages/perseus-editor/src/widgets/__tests__/interactive-graph-editor.test.tsx` Storybook - http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--interactive-graph-segment (and other graph types) - Toggle between static and not static graphs - Confirm that the start coords UI goes away when the graph is static, and the "correct" graph coords are used - Confirm that the start coords UI is present when the graph is not static, and the start coords are used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (aef4558) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1610 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1610 |
Size Change: +96 B (+0.01%) Total Size: 860 kB
ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1610 +/- ##
==========================================
+ Coverage 70.22% 70.46% +0.24%
==========================================
Files 548 573 +25
Lines 107262 111747 +4485
Branches 7799 11222 +3423
==========================================
+ Hits 75326 78748 +3422
- Misses 31748 32999 +1251
+ Partials 188 0 -188 see 1121 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
The parent pull-request (#1609) has been merged into |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@33.1.0 ### Minor Changes - [#1452](#1452) [`3980a36fa`](3980a36) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Implementation of SVG-based Axis Tick Labels for Interactive Graph ### Patch Changes - [#1609](#1609) [`981047211`](9810472) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph] Remove the start-coords-ui flags - [#1610](#1610) [`e9b317ca0`](e9b317c) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Remove the start coords UI if the graph is static - [#1608](#1608) [`737fe30b4`](737fe30) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph] Remove the interactive-graph-locked-feature-m2b flag ## @khanacademy/perseus-editor@14.1.1 ### Patch Changes - [#1609](#1609) [`981047211`](9810472) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph] Remove the start-coords-ui flags - [#1607](#1607) [`1b340b197`](1b340b1) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Use Wonder Blocks TextArea in the graph description settings UI - [#1610](#1610) [`e9b317ca0`](e9b317c) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Remove the start coords UI if the graph is static - [#1608](#1608) [`737fe30b4`](737fe30) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph] Remove the interactive-graph-locked-feature-m2b flag - Updated dependencies \[[`981047211`](9810472), [`e9b317ca0`](e9b317c), [`737fe30b4`](737fe30), [`3980a36fa`](3980a36)]: - @khanacademy/perseus@33.1.0
Summary:
When the graph is static, it uses the "correct" graph's coords to set
the coords on the now noninteractive graph. This makes the start coords
UI useless, as those coords will not be used.
Issue: https://khanacademy.atlassian.net/browse/LEMS-2318
Test plan:
yarn jest packages/perseus-editor/src/widgets/__tests__/interactive-graph-editor.test.tsx
Storybook
"correct" graph coords are used
and the start coords are used
Screen.Recording.2024-09-10.at.3.10.52.PM.mov