Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group v1 keypad code into a keypad-v1 dir #527

Merged
merged 6 commits into from
May 11, 2023
Merged

Group v1 keypad code into a keypad-v1 dir #527

merged 6 commits into from
May 11, 2023

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented May 11, 2023

Summary:

All this PR does is group v1 keypad code into a single directory.

Test plan:

Nothing should change, just moving code.

@handeyeco handeyeco self-assigned this May 11, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 11, 2023

🦋 Changeset detected

Latest commit: c991e3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@handeyeco handeyeco changed the title rename keypad dir to keypad-v2 Group v1 keypad code into a keypad-v1 dir May 11, 2023
@handeyeco handeyeco marked this pull request as ready for review May 11, 2023 19:02
@khan-actions-bot khan-actions-bot requested a review from a team May 11, 2023 19:02
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented May 11, 2023

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/quiet-ravens-drop.md, packages/math-input/src/index.ts, packages/math-input/src/components/input/math-input.tsx, packages/math-input/src/components/keypad-legacy/compute-layout-parameters.ts, packages/math-input/src/components/keypad-legacy/corner-decal.tsx, packages/math-input/src/components/keypad-legacy/echo-manager.tsx, packages/math-input/src/components/keypad-legacy/empty-keypad-button.tsx, packages/math-input/src/components/keypad-legacy/expression-keypad.tsx, packages/math-input/src/components/keypad-legacy/fraction-keypad.tsx, packages/math-input/src/components/keypad-legacy/gesture-manager.ts, packages/math-input/src/components/keypad-legacy/gesture-state-machine.ts, packages/math-input/src/components/keypad-legacy/icon.tsx, packages/math-input/src/components/keypad-legacy/keypad-button.tsx, packages/math-input/src/components/keypad-legacy/keypad-container.tsx, packages/math-input/src/components/keypad-legacy/keypad.tsx, packages/math-input/src/components/keypad-legacy/many-keypad-button.tsx, packages/math-input/src/components/keypad-legacy/math-icon.tsx, packages/math-input/src/components/keypad-legacy/multi-symbol-grid.tsx, packages/math-input/src/components/keypad-legacy/multi-symbol-popover.tsx, packages/math-input/src/components/keypad-legacy/navigation-pad.tsx, packages/math-input/src/components/keypad-legacy/node-manager.ts, packages/math-input/src/components/keypad-legacy/popover-manager.tsx, packages/math-input/src/components/keypad-legacy/popover-state-machine.ts, packages/math-input/src/components/keypad-legacy/provided-keypad.tsx, packages/math-input/src/components/keypad-legacy/styles.ts, packages/math-input/src/components/keypad-legacy/svg-icon.tsx, packages/math-input/src/components/keypad-legacy/text-icon.tsx, packages/math-input/src/components/keypad-legacy/touchable-keypad-button.tsx, packages/math-input/src/components/keypad-legacy/two-page-keypad.tsx, packages/math-input/src/components/keypad-legacy/velocity-tracker.ts, packages/math-input/src/components/keypad-legacy/z-indexes.ts, packages/math-input/src/components/keypad-legacy/__tests__/gesture-state-machine.test.ts, packages/math-input/src/components/keypad-legacy/__tests__/node-manager.test.ts, packages/math-input/src/components/keypad-legacy/__tests__/two-page-keypad.test.tsx, packages/math-input/src/components/keypad-legacy/iconography/arrow.js, packages/math-input/src/components/keypad-legacy/iconography/backspace.js, packages/math-input/src/components/keypad-legacy/iconography/cdot.js, packages/math-input/src/components/keypad-legacy/iconography/cos.js, packages/math-input/src/components/keypad-legacy/iconography/cube-root.js, packages/math-input/src/components/keypad-legacy/iconography/dismiss.js, packages/math-input/src/components/keypad-legacy/iconography/divide.js, packages/math-input/src/components/keypad-legacy/iconography/down.js, packages/math-input/src/components/keypad-legacy/iconography/equal.js, packages/math-input/src/components/keypad-legacy/iconography/exp-2.js, packages/math-input/src/components/keypad-legacy/iconography/exp-3.js, packages/math-input/src/components/keypad-legacy/iconography/exp.js, packages/math-input/src/components/keypad-legacy/iconography/frac.js, packages/math-input/src/components/keypad-legacy/iconography/geq.js, packages/math-input/src/components/keypad-legacy/iconography/gt.js, packages/math-input/src/components/keypad-legacy/iconography/index.js, packages/math-input/src/components/keypad-legacy/iconography/jump-into-numerator.js, packages/math-input/src/components/keypad-legacy/iconography/jump-out-base.js, packages/math-input/src/components/keypad-legacy/iconography/jump-out-denominator.js, packages/math-input/src/components/keypad-legacy/iconography/jump-out-exponent.js, packages/math-input/src/components/keypad-legacy/iconography/jump-out-numerator.js, packages/math-input/src/components/keypad-legacy/iconography/jump-out-parentheses.js, packages/math-input/src/components/keypad-legacy/iconography/left-paren.js, packages/math-input/src/components/keypad-legacy/iconography/left.js, packages/math-input/src/components/keypad-legacy/iconography/leq.js, packages/math-input/src/components/keypad-legacy/iconography/ln.js, packages/math-input/src/components/keypad-legacy/iconography/log-n.js, packages/math-input/src/components/keypad-legacy/iconography/log.js, packages/math-input/src/components/keypad-legacy/iconography/lt.js, packages/math-input/src/components/keypad-legacy/iconography/minus.js, packages/math-input/src/components/keypad-legacy/iconography/neq.js, packages/math-input/src/components/keypad-legacy/iconography/parens.js, packages/math-input/src/components/keypad-legacy/iconography/percent.js, packages/math-input/src/components/keypad-legacy/iconography/period.js, packages/math-input/src/components/keypad-legacy/iconography/plus.js, packages/math-input/src/components/keypad-legacy/iconography/radical.js, packages/math-input/src/components/keypad-legacy/iconography/right-paren.js, packages/math-input/src/components/keypad-legacy/iconography/right.js, packages/math-input/src/components/keypad-legacy/iconography/sin.js, packages/math-input/src/components/keypad-legacy/iconography/sqrt.js, packages/math-input/src/components/keypad-legacy/iconography/tan.js, packages/math-input/src/components/keypad-legacy/iconography/times.js, packages/math-input/src/components/keypad-legacy/iconography/up.js, packages/math-input/src/components/keypad-legacy/store/actions.ts, packages/math-input/src/components/keypad-legacy/store/echo-reducer.ts, packages/math-input/src/components/keypad-legacy/store/index.ts, packages/math-input/src/components/keypad-legacy/store/input-reducer.ts, packages/math-input/src/components/keypad-legacy/store/keypad-reducer.ts, packages/math-input/src/components/keypad-legacy/store/layout-reducer.ts, packages/math-input/src/components/keypad-legacy/store/pager-reducer.ts, packages/math-input/src/components/keypad-legacy/store/shared.ts, packages/math-input/src/components/keypad-legacy/store/types.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

Size Change: -261 B (0%)

Total Size: 790 kB

Filename Size Change
packages/math-input/dist/es/index.js 58.3 kB -261 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38 kB
packages/kmath/dist/es/index.js 4.13 kB
packages/perseus-editor/dist/es/index.js 254 kB
packages/perseus-error/dist/es/index.js 705 B
packages/perseus-linter/dist/es/index.js 21.2 kB
packages/perseus/dist/es/index.js 397 kB
packages/pure-markdown/dist/es/index.js 3.65 kB
packages/simple-markdown/dist/es/index.js 12.6 kB

compressed-size-action

@coveralls
Copy link
Collaborator

coveralls commented May 11, 2023

Coverage Status

Coverage: 43.348%. Remained the same when pulling c991e3f on group-v1-keypad into d9759ea on main.

@nedredmond
Copy link
Contributor

small request: rename keypad v1 to legacy-keypad or similar and leave v2 alone for the sake of others working in parallel in this codebase

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (2a6157e) and published it to npm. You
can install it using the tag PR527.

Example:

yarn add @khanacademy/perseus@PR527

@handeyeco
Copy link
Contributor Author

@nedredmond Done 👍

@handeyeco handeyeco merged commit bd66253 into main May 11, 2023
@handeyeco handeyeco deleted the group-v1-keypad branch May 11, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants