Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install pyparsing #22

Closed
wants to merge 1 commit into from
Closed

Install pyparsing #22

wants to merge 1 commit into from

Conversation

kpet
Copy link

@kpet kpet commented Sep 9, 2022

Now required to build the Vulkan specifications (scripts/parse_dependency.py)

Signed-off-by: Kevin Petit kevin.petit@arm.com

@kpet
Copy link
Author

kpet commented Sep 9, 2022

Should this be done in the vulkan-docs images instead?

Now required to build the Vulkan specifications (scripts/parse_dependency.py)

Signed-off-by: Kevin Petit <kevin.petit@arm.com>
@oddhack
Copy link
Collaborator

oddhack commented Sep 10, 2022

I think you may be experiencing a Docker caching issue? The current asciidoctor-spec image has pyparsing installed, though not explicit in the Dockerfile:

$ docker run -it --rm khronosgroup/docker-images@sha256:278e239fecc0ae30be582c8c639783d4245ec61e00967ce8008a4cf0eb478a0a pip3 list | grep pyparsing

pyparsing 2.4.7

However, we've experienced some severe and AFAICT, unfixable issues with various gitlab / github CI systems not updating the image they pull after we push new ones to Dockerhub - which is why the Vulkan CI scripts now reference specific image SHAs. Possibly that's what you're experiencing?

Should this be done in the vulkan-docs images instead?

No. That's legacy at this point, hopefully can be removed entirely eventually.

@kpet
Copy link
Author

kpet commented Sep 12, 2022

However, we've experienced some severe and AFAICT, unfixable issues with various gitlab / github CI systems not updating the image they pull after we push new ones to Dockerhub - which is why the Vulkan CI scripts now reference specific image SHAs. Possibly that's what you're experiencing?

Right, that's good to know, thanks! This is likely what I'm experiencing. I'll investigate with that in mind.

Closing this PR since the images apparently already have pyparsing.

@kpet kpet closed this Sep 12, 2022
@rpavlik
Copy link
Contributor

rpavlik commented Sep 12, 2022

Yep, that's exactly why we started using numbers 😁 didn't occur to me to use hashes to be honest but that's a better idea I think.

@oddhack
Copy link
Collaborator

oddhack commented Nov 29, 2022

Yep, that's exactly why we started using numbers grin didn't occur to me to use hashes to be honest but that's a better idea I think.

N.b. I actually learned about that trick in a response to my ranting on my FB :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants