Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vulkan Events if available #192

Closed
billhollings opened this issue Jul 6, 2018 · 9 comments
Closed

Add support for Vulkan Events if available #192

billhollings opened this issue Jul 6, 2018 · 9 comments
Labels
Completed Issue has been fixed, or enhancement implemented. Enhancement

Comments

@billhollings
Copy link
Contributor

The latest version of Metal now supports some form of behaviour similar to Vulkan Events.

@iOS4all
Copy link

iOS4all commented Jul 13, 2018

@billhollings please can we add vulkan to ppsspp to could select it as a backend?
Of course I mean iOS devices.
So if there’s any cydia source to could install MoltenVK it’ll be great

@billhollings
Copy link
Contributor Author

@iOS4all

Is this related to Vulkan Events? It sounds like this should be posted as a separate enhancement topic.

We definitely encourage the PPSSPP team integrate MoltenVK into their Vulkan implementation for iOS and macOS...and we would be happy to provide assistance.

@mbarriault
Copy link
Collaborator

It looks like events might be able to implemented with a combination of MTLSharedEvent (for CPU triggering) and MTLEvent (for stage synchronization).

@kristofferR
Copy link

The lack of Vulkan Events support in MoltenVK is currently blocking DXVK support:
doitsujin/dxvk#1077 (comment)

@billhollings
Copy link
Contributor Author

SIGGRAPH generated some good feedback regarding interest in this feature.

I'll start working on this feature this week. If anyone has started work on this already...or has design ideas...please let me know.

@cdavis5e

@cdavis5e
Copy link
Collaborator

cdavis5e commented Aug 5, 2019

I haven't started on this.

I have, however, looked at gfx-rs's implementation. They're just delaying command buffer submission, similar to what we do with VkSemaphore. We could probably have that as a fallback in case MTLSharedEvent isn't supported.

@billhollings
Copy link
Contributor Author

billhollings commented Aug 10, 2019

Support added in PR #708.

@billhollings billhollings added the Completed Issue has been fixed, or enhancement implemented. label Aug 10, 2019
@ovvldc
Copy link

ovvldc commented Aug 14, 2019

So this can now be removed from the list of Known Limitations in https://github.com/KhronosGroup/MoltenVK/blob/master/Docs/MoltenVK_Runtime_UserGuide.md#limitations ?

That list its getting impressively short, by the way.

@billhollings
Copy link
Contributor Author

So this can now be removed from the list of Known Limitations

Oops! Good catch! I'll update the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed Issue has been fixed, or enhancement implemented. Enhancement
Projects
None yet
Development

No branches or pull requests

6 participants