Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy dependency #164

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

mt-krainski
Copy link
Contributor

Taking over #158.

This fixes the installation process so that installing nnef-tools will now also install numpy as it is a build and runtime dependency. This can now be installed in virtual environments without manually specifying the dependency on numpy as well as with other package managers e.g. poetry.

I locked the numpy version to be above 1.13 because that's when __NUMPY_SETUP__ became deprecated. If this was to support older versions of numpy, we'd have to add a try-except block to check for __NUMPY_SETUP__ in finalize_options. We can also lock the version higher.

setup_requires is required, without it the build doesn't work - I think with setup_required, numpy is installed before building nnef-tools. Without it it might be installed after.

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2023

CLA assistant check
All committers have signed the CLA.

@gyenesvi
Copy link
Contributor

gyenesvi commented Apr 26, 2023

@mt-krainski, so this is to replace #158 right? I like this solution, it looks cleaner to me. So if we merge this one, we can drop the other one, right?

@mt-krainski
Copy link
Contributor Author

That is correct!

@gyenesvi gyenesvi merged commit 21a2576 into KhronosGroup:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants