Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over #158.
This fixes the installation process so that installing nnef-tools will now also install numpy as it is a build and runtime dependency. This can now be installed in virtual environments without manually specifying the dependency on numpy as well as with other package managers e.g. poetry.
I locked the numpy version to be above 1.13 because that's when
__NUMPY_SETUP__
became deprecated. If this was to support older versions of numpy, we'd have to add a try-except block to check for__NUMPY_SETUP__
infinalize_options
. We can also lock the version higher.setup_requires
is required, without it the build doesn't work - I think withsetup_required
,numpy
is installed before building nnef-tools. Without it it might be installed after.