-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker for remaining refpage todo items #70
Comments
See #72 for WIP MR addressing some of these points. |
#83 adds extension refpages (static) and some of the missing index pages. |
OpenCL 2.2 refpages are published on khronos.org/registry/OpenCL/ now. More could be done, of course. |
#116 cleans up a bunch of broken internal refpage links, and adds a missing static page (possibly out of date) listing allowed enum values for enumerated cl_* types. |
@bashbaug commented on #116, and I responded:
|
@bashbaug @ntrevett - @outofcontrol brought up the 2.2 refpage missing link issue again in the registry repo. Here's where it stands, as best I recall:
Let me know how you want to proceed. |
@outofcontrol I generated a tweaked version of the CL 2.2 refpages under https://www.khronos.org/registry/OpenCL/sdk/2.2/docs/man/test/ . Could you run your link checker over it? I tried to get all the dangling pages you mentioned in KhronosGroup/OpenCL-Registry#94 but I can't be sure without automatic verification. |
Missing pages: /test/atomic_flag_test_and_set_explicitatomic_init.html |
@bashbaug I was puzzled by why the 2.2 Extensions Specification wasn't resolving get_image_num_mip_levels until I realized that it was generated from a 2019 snapshot of the tree while the refpages branch I'm working in for the moment were done in 2020, and the cl_khr_mipmap_image section didn't contain those calls until later. Do you think it would be OK for me to update the 2.2 OpenCL_Ext.html from the https://github.com/KhronosGroup/OpenCL-Docs/tree/update-refpages-2.2-from-0a92eee branch? |
Please try again. I had not updated the .htaccess file properly to rewrite those. |
Yeah, this sounds right... it looks like the last v2.2 spec was tagged in July 2019 (V2.2-11, 2aaf7b5) and the mipmaps built-ins weren't re-added until later (#149, bd449aa). Do you happen to know when the 2.2 refpages were built? Was it from commit 0a92eee?
Would you only update the extension spec? In theory it would be OK to update any of the 2.2 specs to any commit before the v3.0.1-Provisional tag (fafc202). The extension spec especially should be pretty low-risk to update and when I took a look at the diffs they were pretty minor. Another option would would be to link the 2.2 refpages to the 3.0-unified extensions spec since the extension spec has been unified for some time now, although this might be a little confusing and it does add a coupling between the 2.2 refpages and the 3.0 specs that wouldn't exist otherwise. |
You can sort of puzzle it out from the footer information on the pages although it's oddly encoded - Version V2.2-11-107-g6eaa3d2 => commit 6eaa3d2 + various minor fixes I made, which were then committed under the next commit 0a92eee.
That's all that's needed and seems like less work for you to verify.
That seems better than regenerating a 2.2 OpenCL_Ext spec just for this reason. Will change accordingly. |
Pushed an update to https://github.com/KhronosGroup/OpenCL-Docs/tree/update-refpages-2.2-from-0a92eee for the get_image_num_mip_levels issue. I think this is completely fixed for the 2.2 pages now, pending @outofcontrol's link-checker. |
0 broken links now. |
@bashbaug I (edit: went) ahead and updated the 2.2 pages from the https://github.com/KhronosGroup/OpenCL-Docs/tree/update-refpages-2.2-from-0a92eee branch in order to get this off the table and move on to 3.0 pages. |
Closing. Will open a new issue for 3.0 refpages as those progress. |
These are the significant remaining steps following #67 before we can replace the old Docbook reference pages with ones extracted from the specification sources:
Missing short descriptions in API refpage markupAdd cross-references in API refpage markupAlso add to Apache redirects in published refpages on khronos.org.Modify C / Doc generator scripts to not try and align function parameter / member names per BenGenerate aliases (either HTML or server-side redirects via .htaccess) for OpenCL C refpages containing many functions.TOC page for the entire refpage set.Static part of TOC is out of dateSome missing OpenCL C pages that will probably have to be static, like 'attribute' and 'dataTypes'.Missing API (mostly, some C) pages, found by running @outofcontrol's link-checker against the published pages. The majority of these are API handle types.No refpages for KHR extensions, yet. It is difficult to mark up the extension diff specs for autoextraction as they're currently constructed, and it may be best to retain the static refpages (converted to asciidoctor) until such time as a unified core + extensions spec might be generated.Nothing done for C++ or Environment specs, yet.(crossed out because these are beyond the scope of the refpage project - if the WG wants to add new categories of pages, this work could be done).The text was updated successfully, but these errors were encountered: