hello_xr: Make Vulkan's mirror window optional #395
Conversation
utzcoz
changed the title
utzcoz
changed the title
|
An issue (number 1984) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1984 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
|
The WG would prefer having it as a command-line argument, suspecting that the next person who wants to use it will submit a PR re-enabling it 🤣 Making it a configuration option in CMake might be a useful halfway point I forgot to raise during the call. |
Do I need to support it at this PR or next PR. It is all fine to me. |
|
I think they didn't want to merge this one, so probably either keep this patch locally or try a Cmake or runtime option. |
No problem. I will try to improve this PR with cmake or runtime option. |
utzcoz
force-pushed
the
disable-USE_MIRROR_WINDOW-default
branch
2 times, most recently
from
87efbef
to
6289fde
Compare
utzcoz
changed the title
utzcoz
force-pushed
the
disable-USE_MIRROR_WINDOW-default
branch
2 times, most recently
from
4aace6c
to
8d3ab5e
Compare
The Vulkan's mirror window is disabled default, and we use "--mirrorwindow|-mw true" to enable it. Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
utzcoz
force-pushed
the
disable-USE_MIRROR_WINDOW-default
branch
from
8d3ab5e
to
11b0a24
Compare
|
Hi @rpavlik , I updated the patch to make mirror window optional with new command argument: --mirrorwindow|-mw. Please help review new patch to check what extra things that I need to do to meet requirements. Thanks. |
I decide to disable it default.
Fixes: #392.