HLSL: Add task(amplification) shader support #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try
commented
Mar 18, 2023
spirv_hlsl.cpp
Outdated
| } | ||
| else | ||
| { | ||
| SPIRV_CROSS_THROW("Amplification shader in HLSL must have payload"); |
There was a problem hiding this comment.
I've tested with DXC: empty struct as payload compiles, yet produces invalid byte-code
bcf5408759f3.hlsl:17:5: error: For amplification shader with entry 'main', payload size 4 is greater than declared size of 0 bytes
https://shader-playground.timjones.io/8d8dbf3b63aa67aa3d000327b56915dd
There was a problem hiding this comment.
Could you just make a dummy struct with one int?
There was a problem hiding this comment.
Haven't tested yet, but probably 'one-int' wont work, because task-payload should match mesh-payload in order to link.
HansKristian-Work
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1974