Remove Kernel from ConstantSampler enum values #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can only be used with OpConstantSampler, so they are naturally restricted from being used in places where they're not supported.
gnl21
force-pushed
the
sampler-enums
branch
from
b54bf5f
to
44e698b
Compare
bashbaug
approved these changes
Sep 13, 2023
dneto0
added a commit
to dneto0/SPIRV-Tools
that referenced
this pull request
Sep 13, 2023
This corresponds to header change KhronosGroup/SPIRV-Headers#378
alan-baker
pushed a commit
to KhronosGroup/SPIRV-Tools
that referenced
this pull request
Sep 13, 2023
* Update SPIRV-Headers, add cache control operand kinds Adds SPV_OPERAND_TYPE_LOAD_CACHE_CONTROL and SPV_OPERAND_TYPE_STORE_CACHE_CONTROL, from SPV_INTEL_cache_controls Fixes: #5404 * Update tests: remove Kernel from constant sampler enum dependencies This corresponds to header change KhronosGroup/SPIRV-Headers#378
cassiebeckley
pushed a commit
to cassiebeckley/SPIRV-Tools
that referenced
this pull request
Sep 20, 2023
) * Update SPIRV-Headers, add cache control operand kinds Adds SPV_OPERAND_TYPE_LOAD_CACHE_CONTROL and SPV_OPERAND_TYPE_STORE_CACHE_CONTROL, from SPV_INTEL_cache_controls Fixes: KhronosGroup#5404 * Update tests: remove Kernel from constant sampler enum dependencies This corresponds to header change KhronosGroup/SPIRV-Headers#378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can only be used with OpConstantSampler, so they are naturally restricted from being used in places where they're not supported.