Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rerun clang-format with 132 line width #233

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

spencer-lunarg
Copy link
Contributor

I plan after this lands to make a .git-blame-ignore-revs file with the commit, this way git blame on any modern git tool (and GitHub) will ignore this PR

@cassiebeckley
Copy link
Contributor

Is there a specific reason why you want to override the Google style guide default for this?

@spencer-lunarg
Copy link
Contributor Author

Is there a specific reason why you want to override the Google style guide default for this?

Comments like this or while subjective, I feel this is not easy to read

image

and the style guide was always a "baseline" in my personal vision, we do this for the Validation Layers too

also (subjective) I never understood why it was 80 char wide only to begin with

Copy link
Contributor

@cassiebeckley cassiebeckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. I don't think we can override the style guide for internal projects at Google, but I have no personal objections to this :)

@spencer-lunarg spencer-lunarg merged commit dc6582b into KhronosGroup:main Nov 18, 2023
5 checks passed
@spencer-lunarg spencer-lunarg deleted the spencer-lunarg-cf branch November 18, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants