Updated spirv.h header. Fixes SPV_VERSION macro #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+2 |
The SPV_VERSION macro value was updated to be 0x10000. Previously it was missing the "0x" prefix, which caused confusion. The value of the const unsigned int SpvVersion has always been 0x00010000. That's what should appear as the version word in the SPIR-V header. The SPV_VERSION symbol is to be used in preprocessor directives.
dneto0
force-pushed
the
update-spirv-h
branch
from
1e44cd7
to
3958c90
Compare
|
Rebased |
robclark
pushed a commit
to freedreno/SPIRV-LLVM
that referenced
this pull request
Jan 26, 2018
The specification defines the version number as > 0 | Major Number | Minor Number | 0 which results in version `1.00` being defined as `0x00010000`. The previous value was set to `10000`, resulting in `0x00002710`. See: KhronosGroup/SPIRV-Tools#15
Hopetech
pushed a commit
to Hopetech/SPIRV-LLVM-Tools
that referenced
this pull request
Feb 23, 2018
The specification defines the version number as > 0 | Major Number | Minor Number | 0 which results in version `1.00` being defined as `0x00010000`. The previous value was set to `10000`, resulting in `0x00002710`. See: KhronosGroup/SPIRV-Tools#15
AlexeySotkin
pushed a commit
to AlexeySotkin/SPIRV-LLVM
that referenced
this pull request
Mar 12, 2018
The specification defines the version number as > 0 | Major Number | Minor Number | 0 which results in version `1.00` being defined as `0x00010000`. The previous value was set to `10000`, resulting in `0x00002710`. See: KhronosGroup/SPIRV-Tools#15
Hopetech
pushed a commit
to Hopetech/SPIRV-LLVM-Tools
that referenced
this pull request
Mar 22, 2018
The specification defines the version number as > 0 | Major Number | Minor Number | 0 which results in version `1.00` being defined as `0x00010000`. The previous value was set to `10000`, resulting in `0x00002710`. See: KhronosGroup/SPIRV-Tools#15
AlexeySotkin
pushed a commit
to AlexeySotkin/SPIRV-LLVM
that referenced
this pull request
Apr 3, 2018
The specification defines the version number as > 0 | Major Number | Minor Number | 0 which results in version `1.00` being defined as `0x00010000`. The previous value was set to `10000`, resulting in `0x00002710`. See: KhronosGroup/SPIRV-Tools#15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new spirv.h from the SPIR-V registry.
The SPV_VERSION macro value was updated to be 0x10000.
Previously it was missing the "0x" prefix, which caused
confusion.
The value of the const unsigned int SpvVersion has always
been 0x00010000. That's what should appear as the version
word in the SPIR-V header.
The SPV_VERSION symbol is to be used in preprocessor directives.