Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid use of type manager in extact->construct folding #5684

Merged
merged 2 commits into from
May 31, 2024

Commits on May 23, 2024

  1. Avoid use of type manager in extact->construct folding

    When dealing with structs the type manager merge two different structs
    into a single entry if they have all of the same decorations and
    element types. This is because they hash to the same value in the hash
    table. This can cause problems if you need to get the id of a type from
    the type manager because you could get either one. In this case, it
    returns the wrong one.
    
    The fix avoids using the type manager in one place. I have not
    looked closely at other places the type manager is used to make
    sure it is used safely everywhere.
    
    Fixes KhronosGroup#5624
    s-perron committed May 23, 2024
    Configuration menu
    Copy the full SHA
    519a78d View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Remove use of TypeManager::GetId

    This removes a use of TypeManager::GetId by keeping the id around. This
    avoid a potential problem if the type manager gets confused. These types
    of bugs are hard to generate test cases for, so I do not have a test.
    However, existing tests make sure that do not regress.
    s-perron committed May 27, 2024
    Configuration menu
    Copy the full SHA
    944f651 View commit details
    Browse the repository at this point in the history