Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add move semantics for non-raii hpp handles. (#1919) #1923

Closed
wants to merge 2 commits into from
Closed

Add move semantics for non-raii hpp handles. (#1919) #1923

wants to merge 2 commits into from

Conversation

siukosev
Copy link
Contributor

@siukosev siukosev commented Jul 18, 2024

Added define VULKAN_HPP_HANDLES_MOVE_EXCHANGE which enables exchange in handles' move-constructors.
Moved exchange from raii to root vk namespace.

closes #1919

@siukosev
Copy link
Contributor Author

siukosev commented Jul 18, 2024

Had issues with codegen: clang-format makes too much redundant changes to existing headers. I suppose it's because of newer version(16 or 18).
Tell me if I have to install clang-format 15 for correct behavior.

@asuessenbach
Copy link
Contributor

Great PR, thank you!

Would be perfect if you could use clang-format 15 and also add the generated files, but I would also accept your change as is...
But please adjust the year in the copyright header in the two new files, and the comment about ArrayProxy in the test. Also, I don't get why you check agains nullptr there in two directions?

@siukosev
Copy link
Contributor Author

Two directions nullptr check: it was a copy-paste from Handles test. I will remove redundant checks.

@siukosev
Copy link
Contributor Author

Successfully reproduced build env. Will update PR after 1.3.291 headers pipeline completion

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2024

CLA assistant check
All committers have signed the CLA.

@asuessenbach
Copy link
Contributor

Looks great now, thanks a lot for your contribution.

@siukosev siukosev closed this by deleting the head repository Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move semantics for non-raii handles
3 participants