You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on testing calibrated timestamps I came across the timestamps example and on code review spotted a inconsistency in the code vs the specs for the VK_EXT_calibrated_timestamps docs.
pMaxDeviation is a pointer to a 64-bit unsigned integer value in which the strictly positive maximum deviation, in nanoseconds, of the calibrated timestamp values is returned.
It looks to me like the code needs to be reorganized a little to pass a pointer to a single value rather than a vector.
The text was updated successfully, but these errors were encountered:
While working on testing calibrated timestamps I came across the timestamps example and on code review spotted a inconsistency in the code vs the specs for the VK_EXT_calibrated_timestamps docs.
The problem lines of code are (https://github.com/KhronosGroup/Vulkan-Samples/blob/main/samples/extensions/calibrated_timestamps/calibrated_timestamps.cpp#L827) :
The max_deviations is initialized like it's a vector that is the same size of timestamps and as if it'll all be filled in, but the docs for vkGetCalibratedTimestampsEXT suggest a pointer to a uin64_t is required, not a vector<uint64_t>, docs on method:
https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkGetCalibratedTimestampsEXT.html
Later parameters is described as:
It looks to me like the code needs to be reorganized a little to pass a pointer to a single value rather than a vector.
The text was updated successfully, but these errors were encountered: