Headless and GLFW Windows #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAtkinsonArm
requested review from
gpx1000,
SaschaWillems,
asuessenbach,
gary-sweet and
JoseEmilio-ARM
gpx1000
approved these changes
Nov 14, 2022
TomAtkinsonArm
force-pushed
the
windows
branch
2 times, most recently
from
f4ad839
to
8c95f34
Compare
* std filesystem more tests and fixes recursive tests more tests remove order specific checks from tests review comments * fix duplicated check * review changes
TomAtkinsonArm
force-pushed
the
windows
branch
from
8c95f34
to
4943efa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Headless and GLFW windows back to the project. Events are forwarded though the Event Bus interface.
No need to pass Platform anymore as the Event Bus acts as the communication mechanism.
Headless and GLFW tests included. GLFW tests will not work in the CI so these require
VKB_TEST_GLFWlocally. All GLFW tests pass locally. We could add a small compile time executable to automatically trigger GLFW tests if a GPU is available.