-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STD Filesystem VFS #495
Merged
TomAtkinsonArm
merged 3 commits into
KhronosGroup:framework/v2.0
from
TomAtkinsonArm:std_filesystem
Jul 29, 2022
Merged
STD Filesystem VFS #495
TomAtkinsonArm
merged 3 commits into
KhronosGroup:framework/v2.0
from
TomAtkinsonArm:std_filesystem
Jul 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAtkinsonArm
requested review from
gpx1000,
SaschaWillems,
asuessenbach,
gary-sweet and
JoseEmilio-ARM
July 10, 2022 21:46
Closed
TomAtkinsonArm
force-pushed
the
std_filesystem
branch
2 times, most recently
from
July 21, 2022 13:22
0e3fbed
to
d1fc5e2
Compare
more tests and fixes recursive tests more tests remove order specific checks from tests review comments
Well, the PR actually LGTM.
|
Merging so that #506 may be applied on top |
TomAtkinsonArm
added a commit
to TomAtkinsonArm/Vulkan-Samples
that referenced
this pull request
Jul 29, 2022
* std filesystem more tests and fixes recursive tests more tests remove order specific checks from tests review comments * fix duplicated check * review changes
TomAtkinsonArm
added a commit
to TomAtkinsonArm/Vulkan-Samples
that referenced
this pull request
Nov 21, 2022
* std filesystem more tests and fixes recursive tests more tests remove order specific checks from tests review comments * fix duplicated check * review changes
TomAtkinsonArm
added a commit
to TomAtkinsonArm/Vulkan-Samples
that referenced
this pull request
Nov 21, 2022
* std filesystem more tests and fixes recursive tests more tests remove order specific checks from tests review comments * fix duplicated check * review changes
TomAtkinsonArm
added a commit
that referenced
this pull request
Nov 21, 2022
* window interface * headless window * GLFW window * add VKB_TEST_GLFW * fix glfw errors * add samples_launcher window improvements * STD Filesystem VFS (#495) * std filesystem more tests and fixes recursive tests more tests remove order specific checks from tests review comments * fix duplicated check * review changes * GLFW window * add VKB_TEST_GLFW * directly create a surface * Direct to Display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces OS specific filesystem implementations with std filesystem
This is significantly slower when it comes to enumerating files or folders. Likely due to the conversion between path and string. For now I have added a TODO for future reference