-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vulkan Generators #575
Merged
tomadamatkinson
merged 17 commits into
KhronosGroup:framework/v2.0
from
tomadamatkinson:vulkan_generators
Jan 10, 2023
Merged
Vulkan Generators #575
tomadamatkinson
merged 17 commits into
KhronosGroup:framework/v2.0
from
tomadamatkinson:vulkan_generators
Jan 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomadamatkinson
requested review from
gpx1000,
SaschaWillems,
asuessenbach,
gary-sweet and
JoseEmilio-ARM
December 11, 2022 22:15
@asuessenbach resolved your comments and also renamed the generator and header along the same lines |
asuessenbach
approved these changes
Jan 3, 2023
components/vulkan/include/components/vulkan/common/structure_type_helpers.hpp
Show resolved
Hide resolved
Fixed phantom line issue flagged by @asuessenbach. Merging on the original approval as no functional changes were made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #574
The commit history here is longer than it needs to be as it includes some of the changes from the upcoming Vulkan Builders. This will hopefully be squashed and rebased before that PR is merged.
This PR adds the ability to generate Vulkan code fairly easily. A small framework on top of the Vulkan Headers generator allows for small fixed-purpose generators to be created with a minimal amount of code. In the future, I aim to add a Vulkan test framework using these generators.
For now, a single generator is used to create the
get_structure_type_name
helper. This helper is later used in thepNextChain
builder which allows for an easy way to collect a pNext chain without dealing with tracking the chain itself. It will be used in the Instance and Device builder to allow samples to append extensions to the create structs dynamically.See
codegen/vulkan/readme.md
for basic documentation on the generator itself.