Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logger #574

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Add Logger #574

merged 2 commits into from
Dec 14, 2022

Conversation

tomadamatkinson
Copy link
Collaborator

Add spdlog to framework v2.

  • Implements the same setup as framework v1
  • Removes file paths in logs for now (we should be able to solve this with spdlog but I haven't been able to get this to work yet)
  • Adds a test to play around with formats in the future for the different log types
  • Updates spdlog

@tomadamatkinson tomadamatkinson added the framework This is relevant to the framework label Dec 11, 2022
@tomadamatkinson tomadamatkinson self-assigned this Dec 11, 2022
This was referenced Dec 11, 2022
Merged
Merged
@tomadamatkinson tomadamatkinson merged commit 1da6d94 into KhronosGroup:framework/v2.0 Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asuessenbach asuessenbach asuessenbach approved these changes

@gpx1000 gpx1000 Awaiting requested review from gpx1000

@SaschaWillems SaschaWillems Awaiting requested review from SaschaWillems

@gary-sweet gary-sweet Awaiting requested review from gary-sweet

@JoseEmilio-ARM JoseEmilio-ARM Awaiting requested review from JoseEmilio-ARM

Assignees

@tomadamatkinson tomadamatkinson

Labels
framework This is relevant to the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomadamatkinson @asuessenbach