Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layers: Remove excess state object lookups #3541

Merged

Conversation

jeremyg-lunarg
Copy link
Contributor

Remove some places where we were doing unnecessary lookups of
state objects from handles, when there is already a pointer to the
state object available. None of these seem to have a measurable
performance difference, but that might change once we move to
fine grained locking.

Remove some places where we were doing unnecessary lookups of
state objects from handles, when there is already a pointer to the
state object available. None of these seem to have a measurable
performance difference, but that might change once we move to
fine grained locking.
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 1769.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 5523 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 5523 passed.

Copy link
Contributor

@ncesario-lunarg ncesario-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeremyg-lunarg jeremyg-lunarg merged commit 057f9d5 into KhronosGroup:master Nov 17, 2021
@jeremyg-lunarg jeremyg-lunarg deleted the jeremyg-image-get branch November 17, 2021 17:26
Copy link
Contributor

@jzulauf-lunarg jzulauf-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem strangely familiar... LGTM2

@jeremyg-lunarg
Copy link
Contributor Author

These seem strangely familiar... LGTM2

Yes, with a couple of extras.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants