layers: Remove non-template GetFoo() state tracker methods #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 2386. |
|
CI Vulkan-ValidationLayers build # 5534 running. |
|
BTW, this is welcome and long overdue! Thanks. |
Remove these extra wrapper methods so that it easier to find (and change) places where state lookups occur. The one place where wrappers are necessary is where a state object is subclassed. These can probably be templated, once sufficient template magic is acquired. NOTE: This change converts all result variable to 'auto' not 'auto *' because most of these will soon become smart pointers causing the latter to no longer work.
jeremyg-lunarg
force-pushed
the
jeremyg-remove-getfoo
branch
from
e39e588
to
54cb09a
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 2401. |
|
CI Vulkan-ValidationLayers build # 5536 running. |
ncesario-lunarg
approved these changes
Nov 17, 2021
|
CI Vulkan-ValidationLayers build # 5536 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove these extra wrapper methods so that it easier to find
(and change) places where state lookups occur. The one place where
wrappers are necessary is where a state object is subclassed. These
can probably be templated, once sufficient template magic is acquired.
NOTE: This change converts all result variable to 'auto' not 'auto *'
because most of these will soon become smart pointers causing the
latter to no longer work.