tests: Cleanup test to use framework more #8181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 204949. |
spencer-lunarg
commented
Jun 21, 2024
| @@ -109,7 +109,6 @@ TEST_F(PositiveBuffer, DISABLED_PerfGetBufferAddressWorstCase) { | |||
| constexpr size_t N = 1400; | |||
| std::vector<vkt::Buffer> buffers(N); | |||
| VkBufferCreateInfo buffer_ci = vku::InitStructHelper(); | |||
| buffer_ci.sharingMode = VK_SHARING_MODE_EXCLUSIVE; | |||
There was a problem hiding this comment.
InitStructHelper sets everything to zero
except for the few tests who need to care about sharingMode, having it here just causes it to get copy-and-pasted for no good reason
|
CI Vulkan-ValidationLayers build # 16895 passed. |
artem-lunarg
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a friendly 1000+ line clean up of test code to be more unify in using the framework