-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KHR_materials_clearcoat extension #1756
Conversation
Nit: the spec should mention what is the normal map for clearcoat layer when |
I'm sure that this was probably discussed a long time ago but there are other properties that sometimes appear in clear coat parameterizations like anisotropy, ior and tint. I certainly understand the desire to keep our extension simple, both for ease of implementation and for cross-renderer compatibility but I wonder if we're limiting this extension a bit too much. Tint, for example, would be very easy for renders to support. |
@lexaknyazev Done. @MiiBond Thanks. I'm concerned about feature-creep here. I'd like to keep this extension compatible with existing renderers that have a simple clear-coat function. Perhaps there could be a more advanced |
Yeah, that's totally fair. An additional extension at a later date is probably the best way to handle additional parameters that are in use by some runtimes and not others. |
Draft implementation in Blender: KhronosGroup/glTF-Blender-IO#931 |
This is a continuation of #1740. I wasn't able to push updates to UX3D's repo, so I've moved the branch here to the main repo.
The changes here add an Overview and remove the TODOs. @abwood and I also fine-tuned some descriptions of parameters, just for clarification (it will not require any changes to existing implementations).
Alex and I also considered @proog128 comments in #1740 (comment), but until the Appendix B changes are ready to merge, it does not yet make sense to reference them here. Once Appendix B is updated, the descriptions here that reference Appendix B will also need updating as described in the comment.