Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

funny-looking release tag '10-11.0.0'? #2450

Closed
tjaalton opened this issue Nov 5, 2020 · 6 comments
Closed

funny-looking release tag '10-11.0.0'? #2450

tjaalton opened this issue Nov 5, 2020 · 6 comments
Labels
question

Comments

@tjaalton
Copy link

tjaalton commented Nov 5, 2020

Was this tagged by mistake?
@johnkslang
Copy link
Member

glslangValidator.exe -v shows Glslang Version: 10:11.0.0, using the new semantic versioning scheme. (@ben-clayton)

Unfortunately, : as part of the version cannot be in a tag, git doesn't allow that. So, I have wondered about fixing the version to not have a :.

@ben-clayton
Copy link
Contributor

Original discussion about prefixing the glslang version with the SPIR-V generator version here.

Personally, I'm not keen on the : prefix - I would probably just enforce bumping the version major for all SPIR-V generator changes, and document the SPIR-V generator version in the release notes.

@johnkslang
Copy link
Member

FYI, all these numbers are base 10.

@johnkslang
Copy link
Member

Also of fundamental note here is that semantic versioning sounds great for one thing. But once a tool is multiple things it gets difficult, and some compromises are to be expected.

@Biswa96
Copy link
Contributor

Biswa96 commented Nov 12, 2020

I would suggest not to use colon : or hyphen - in version. In ArchLinux, the package version uses those characters for different meanings.

mbakke pushed a commit to guix-mirror/guix that referenced this issue Mar 1, 2021
@oldschoolBavarianReferenceSystem
gnu: glslang: Use 11.0.0 as git-fetch tag.
baec2a0 
* gnu/packages/vulkan.scm (glslang)[source]: Use tag 11.0.0.

From the README.md: "The versioning scheme is being improved, and you might
notice some differences. This is currently WIP, but will be coming soon."

In this curse, they moved the tag 10-11.0.0 to just 11.0.0.

See also <KhronosGroup/glslang#2450>.
@greg-lunarg
Copy link
Contributor

glslang will be using the traditional major.minor.patch for tags going forward and dealing with generator changes per above suggestion from @ben-clayton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tjaalton @johnkslang @greg-lunarg @ben-clayton @Biswa96