GL_EXT_ray_query updates

[neslimsah]

rayQuery extension updates.

[CLAassistant]

All committers have signed the CLA.

[johnkslang]

@neslimsah can you make an account and sign the CLA? Or, possibly have this come from someone who has done that?

Thanks.

[jiaolu]

the test case are raygeneration shader stage. should add graphics and compute shader stages test cases

[neslimsah]

the test case are raygeneration shader stage. should add graphics and compute shader stages test cases

You mean graphics and compute shader stage test cases for rayQuery extention? Thanks.

[jiaolu]

In these test case, it would be better to use rayFlags to pass in the rayQueryInitializeEXT
gl_RayFlagsOpaqueEXT
gl_RayFlagsNoOpaqueEXT
gl_RayFlagsSkipClosestHitShaderEXT

than numerical value.

[johnkslang]

I see bots are reporting:

All checks have passed
2 successful checks

We will need to know why there are only 2 checks. Travis CI, for example, did not run. I see a change to allow 30 minutes, but hopefully that's actually not the point. Some bot runs occasionally fail, due to timeouts, where it appears some part of the process hung. But, I'm not sure now what the current situation is.

[alelenv]

@Tobski @neslimsah : rayQuery should be passed by reference even to user functions similar to samplers right?
Current code seems to do pass by value.
Also rayQuery is modifiable via intrinsics but can't be assigned to so I think the lvalue check should still be there

[Tobski]

@Tobski @neslimsah : rayQuery should be passed by reference even to user functions similar to samplers right?
Current code seems to do pass by value.

I think this is correct? The "rayQuery" itself is a reference. It's a bit weird but I think it's consistent with how we've defined SPIR-V (which is also weird because reasons...). I could be missing something though?

[johnkslang]

I re-reviewed the whole thing.

I only had one nit/question/desired-improvement about the odd switch statement layout above.

Modulo that, I'm okay with this change, but see there might be some open questions you still want to resolve.

After answering my switch statement question, just let me know when your satisfied with it, and I can merge it.

[dgkoch]

@johnkslang looks like all issues have been addressed and is passing now, can we get it merged?

Thanks.

[alelenv]

My question was not resolved and i have filed issue #2150 to discuss/resolve there

[neslimsah]

pass-by-reference issues #2150 and #2153 are fixed by #2157.