Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed condition for glslang-default-resource-limits instalation. #2601

Merged

Conversation

masterleming
Copy link

@masterleming masterleming commented Apr 8, 2021

This way the limits are available to clients that link statically, which might be necessary due to the ORD problem #2346.

This way the limits are available to clients that links statically.
@CLAassistant
Copy link

CLAassistant commented Apr 8, 2021

CLA assistant check
All committers have signed the CLA.

@greg-lunarg
Copy link
Contributor

Looks like the Linux builds are failing.

@masterleming
Copy link
Author

Right, my naïve change did not take into consideration the proper way of defining libraries. It worked only in my narrow and isolated setup. Should be much better now.

@greg-lunarg greg-lunarg added the kokoro:run Trigger Google bot runs label Apr 9, 2021
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label Apr 9, 2021
@greg-lunarg greg-lunarg self-requested a review April 9, 2021 16:33
Copy link
Contributor

@greg-lunarg greg-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@greg-lunarg greg-lunarg merged commit a7f846a into KhronosGroup:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants