Preprocessing line number handling #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceLineSynchronizer is added for keeping track of the last line number and output newlines appropriately if we switch to a new line in the preprocessor.
Everytime we switch to a new source string, the line are reset. We need to reset lastLine and also output newlines appropriately.
antiagainst
changed the title
johnkslang
added a commit
that referenced
this pull request
Jul 24, 2015
Preprocessing line number handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two patches fix the line number handling in preprocessing. It's the preliminary work mentioned in Issue #37.