Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Amphenol G40H11xxxxx 1x1 Mini-SAS HD connector #2048

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

whitequark
Copy link
Contributor

@whitequark whitequark commented Jan 12, 2020

Add Amphenol G40H11xxxxx 1x1 Mini-SAS HD connector. Once this connector is reviewed, I can add 1x2 and 1x4 variants as well.

Datasheet: https://cdn.amphenol-icc.com/media/wysiwyg/files/drawing/g40h1xxxxhr.pdf
Screenshot:
Screenshot_20200112_190355

3D model (proprietary; I will add a README.md with the links once this is merged): https://cdn.amphenol-icc.com/media/wysiwyg/files/3d/sg40h11331hr.zip

3D model holes and pins perfectly match the footprint holes and pads, so I don't think a dimensioned drawing is not necessary here.

Rule violations:

  • F7.2: the datasheet specifies the anchor point, and KLC says that in case of oddly shaped components, the anchor point must follow the datasheet, so that pick-and-place works as intended.
  • F7.3: the datasheet explicitly specifies the pad shape to within ±0.1 mm, and furthermore, there is only one way to place the component anyways.
  • F9.3: I am using manufacturer models as per M1.2, and they use a different orientation than what KiCAD expects.

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@poeschlr poeschlr added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Jan 19, 2020
Copy link
Contributor

@chschlue chschlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • F7.2: As this is a press fit connector, sticking to the datasheet seems reasonable
  • F7.3: Please fix
  • F9.3: Please fix
  • add RefDes on Fab

sas

  • PTH and NPTH dimensions are correct
  • Fab, Silk and CrtYd are incorrect

Note that Fab should represent the actual body outline, an Edge.Cuts line can be added additionally.

@whitequark
Copy link
Contributor Author

whitequark commented Feb 8, 2020

  • F9.3: Please fix

I'll change it, but, can you explain the rationale for this?

@chschlue
Copy link
Contributor

chschlue commented Feb 8, 2020

M1.2 does not invalidate F9.3. In fact, M1.2 is (in technical terminology) utter crap.
The goal of kicad-packages-3D is to collect as many free 3D models for kicad-footprints as possible and FPs should use a standardized 3D model reference so the 3D model can be added later without touching the footprint again.
See also KiCad/kicad-website#435

BTW, this PR also has some wrong dimensions but I'm still working on that.

@whitequark
Copy link
Contributor Author

Fixed F7.3 and F9.3.

I believe there's already RefDes on Fab:

(fp_text user "%R" (at 0 -9) (layer F.Fab)

Will address wrong dimensions a bit later.

@chschlue
Copy link
Contributor

chschlue commented Feb 9, 2020

I believe there's already RefDes on Fab:

Ah, yes, it's hiding behind Silk. Please move inside the Fab outline.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants