-
Notifications
You must be signed in to change notification settings - Fork 950
KLC Addition - PWR and GND pins #879
Comments
Sounds good, can't we put that in one short sentence?
Maybe it is clearer using sub-bullets? |
I would lean towards bullets for clarity, especially as many users are English as a second language. Thoughts? |
Then we better split most rules into bullets! |
I can tackle this. |
I agree on bullets. There are negative and positive power pins. Ground is power pin too. I'd mention control/controlled pins too. Wherever possible, pins should be arranged by function:
|
Hi! I only see obne (special case) problem with these rules: What happens if you try to design a 7905 or comparable neg. regulator ... is the GND pin now at the bottom or at the top? Otherwise: That would be a great addition! Best, |
Great suggestions @diggit I have mocked up some changes here: https://github.com/SchrodingersGat/kicad-library/wiki/KLC Let me know what you think - @CarlPoirier if you're happy with this I'll transfer it to the KiCad page |
@jkriege2 regarding the exception above - I have added a section in the text specifically relating to exceptions. There are always going to be exceptions to every rule! |
I have also added a draft for |
As agreed in #869, 3.2 2. bullet should be improved. There were ideas, but not exact formulation.
|
@diggit I have updated 3.2.2 as requested |
It's great. In 4.4 I'd put the examples on the same line such as in 3.10.4. Rule 3.10 is nice as well. Once it goes live, don't forget to put your name at the top besides mine! |
@CarlPoirier @diggit @jkriege2 let me know if there is anything else that needs changing, otherwise I'll transfer it across :) |
Hi! just some comments:
Best, |
BTW. In the KLC Wiki page https://github.com/KiCad/kicad-library/wiki/Kicad-Library-Convention you could include some graphical examples of some rules for better understanding. |
@keruseykaryu I also had that idea ... but no time so far to prepare some ... I can see if I find some images in the next days/weeks and we discuss them as a new issue? Then we can go forward with the changes above and add the images in a second discussion. OK? Best, |
Please note that I updated my post above (reformulated new rule)! |
@keruseykaryu yes this is a fantastic idea - visual examples would be very helpful. @jkriege2 good suggestions:
|
I have also spotted an inconsistency in the rules. 3.5 -> Refdes must be placed on Silkscreen layer, size=1.0mm 10.5 -> Refdes must be placed on the Fabrication layer, size = 2.0mm This is one that has been the cause of much debate, but we must have the refdes on the silkscreen layer, surely? How should we resolve this? I would suggest removing rules 10.4 and 10.5 as they are covered in 3.5 and 3.6. Further, these are not really "properties" of the footprint more than graphical elements. |
Hi!
Best, |
Hi! I'm also opening an issue to discuss possible images: Best, |
Just to clarify: Both the value and refdes need to be on the fabrication layer. This has been discussed on the mailing list and in the forum thread I linked in the first email. Rule 10.5 and right, 3.5 should have been removed. Carl |
Then to comply with the current usage in the lib, I would suggest this altered rule:
What do you think? I formated the changes in a bold font and the instructions in an italic font. best, |
In the mean time I think that the only issue outstanding is what we say regarding symbol variants... |
I'm repeating a post from above ... what are your thoughts on that?
Best, |
GitHub markdown issue is fixed @poeschlr - list subitems now require three leading spaces (previously two) |
final thoughts on NC pins - should they be visible or invisible? |
I think invisible. If there's no connection, let's not clutter the symbol with those pins. For any pins used in manufacturing or test which the user isn't supposed to connect, they should be visible, but truly NC pins do not need to be seen, IMO. |
@SchrodingersGat When you mention "symbol variants" above, is that how to handle one part that comes in an 8-pad package (like SOIC8) and a 9-pad package (SOIC8 with thermal pad)? Our discussion about if they're called by the footprint name or the manufacturer suffix? The manufacturer suffix seems to have problems, to me. Take HIP2100, for example. Suffixes of Or MC33078. The DIP8 package is MC33078P for On Semi and Texas Instruments, but for STMicro it's MC33078N. So is this called There are times when the part is sole sourced and using the manufacturer suffix is fine, however. And I also recognize that if the DCM file is constructed nicely there would be search terms and/or helpful info available when choosing a part. But the simplicity of putting the generic package name in the symbol name, like Other thoughts? |
I would say as @evanshultz does ;-) One more thing: We currently have these parts with 0.5mm courtyard clearance:
I'm not so sure about that list ... is it based on any norm? If not I would suggest 0.5mm for:
What do you think? |
For the naming ... I would suggest a mixture:
But I would say we SUGGEST that and do not enforce it ... i.e. accept both variants ... Best, |
Ok I have updated again. There is now a FAQ page that lists most of these in long form: https://github.com/SchrodingersGat/kicad-library/wiki/FAQ Also I have updated KLC: https://github.com/SchrodingersGat/kicad-library/wiki/KLC I think we are getting close - I would like to have it finished this weekend! Scripts are also very much improved. Let me know what you think.. @jkriege2 regarding courtyard I think we shall leave it as it is at the moment or we'll never get this new version out. Let's leave that for now and address later. |
Hi! in the FAQ you have Otherwise: FAQs are a great addition! Best, PS: On the courtyard I would object ... I currently have the problem of a PR that changes the courtyard offste of SMD crystals ... maybe we could at least say Best, |
Jan I have fixed the FAQ issues - thanks. Can you provide a proposed diff for the KLC for the courtyard rules? Not quite sure what you are proposing. |
Just for your info over on the forum there is still a very active discussion about power pins: |
Any other issues with this? I'd like to bring this to a close :) |
Suggestion for 5.iv.c:
Or is there an electrical reason to increase courtyard on ALL crystals? Best, |
Otherwise: I'm fine with the current version ... please put it online- Also I don't ahve any more outstanding objections to the scripts ... Best, |
The FAQ is amazing! Excellent job, Oliver! 3.12 Should the FPFilters be prepended with an asterisk too? Imagine the FPFilter is |
3.6 Should the 4 bullet points have text in the "code" style (enclosed in tildes)? 4.12 I asked about the use of 6.1 Remove period 6.4/6.5 Remove comma 6.6.i/6.6.ii Remove "e.g.". 7.4.iii.f Is this text supposed to be italic? 7.7 It looks like the thermal pad stands out because it was selected when the screenshot was taken. Would it be more clear if all "3" pads were unselected so their colors match? 10.4.ii Is this rule only a recommendation or a requirement? Changelog: Check the numbering. There is misalignment and also 2.0 is all "1". Also, the notes in section 5, 6, and the KLC Helper Script have different font/style. And few more things to ask if we will address now or leave for a later revision.
|
I made some changes to the FAQ. Mostly just light editing for clarity or minor typos. Here are a few thoughts there:
|
Hey guys. Any comments on the above? No action here for almost a week. Here's one way to get this done: Give notice that input for 2.0 will only be accepted until some specified time a few days in the future. And that you expect to go live 48 hours (or whatever is good) after the feedback cutoff. Then take that 48 hours to really close all open issues and polish. Anything that doesn't get done, assuming nothing is a showstopper, is up for consideration in 2.1. |
@evanshultz good idea. Otherwise it will never get done. I will address some of your points above this weekend (1st and 2nd April). Let's make feedback cutoff date Friday 31st March and so if there are any serious issues please note them before then. The new KLC check scripts have been running well for ~2weeks without incident so we shall merge those when the new KLC page goes live. |
OK, I can do the merge on the weekend, or next week ;-)
Am 29.03.2017 um 01:02 schrieb Oliver:
… @evanshultz <https://github.com/evanshultz> good idea. Otherwise it will
never get done.
I will address some of your points above this weekend (1st and 2nd
April). Let's make feedback cutoff date Friday 31st March and so if
there are any serious issues please note them before then.
@jkriege2 <https://github.com/jkriege2> @poeschlr
<https://github.com/poeschlr> @diggit <https://github.com/diggit>
The new KLC check scripts have been running well for ~2weeks without
incident so we shall merge those when the new KLC page goes live.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#879 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALacI37UUNmfUA1v-9wZm1PSkr6jMxLVks5rqZGegaJpZM4LZOIT>.
|
Last two topics:
|
And one more, since it's still 31 Mar where I live! We agreed to a separate power unit for multi-gate parts, like quad opamps and dual AND gates. This would allow placing all the power pins in a row and connecting voltages. But what about single gate parts? To me, we should do them all the same. This means ALL power symbols can be in a row, and not having single gate parts with power symbols one place and multi-gate parts with power symbols grouped in another place. |
I don't like the idea of having a separate power unit for a symbol that is otherwise a single unit. Monolithic symbols should not be split.
Can you rephrase this? I'm not quite sure what you are advocating here. |
Regarding split symbols for single-gate parts, then is the dichotomy of power pin placement not an issue? What's the great value in grouping only some power pins together if they're not all grouped? I'm thinking mostly about opamps and single logic gates here, but also LM555 vs LM556. I realize it's late to bring this up, but I think we either do all or nothing. It doesn't help nearly as much with wiring or checking for placement if not all power symbols can be placed together. On the second item, I would like to place the typical "hysteresis" symbol on a logic gate with a Schmitt trigger, but otherwise leave the symbol unadorned. Selecting the Pin Type will provide some type of annotation about the pin use/configuration (like a bubble for inverting pins), but otherwise additional decoration about pin/function shouldn't be added so we don't have the small triangles for clock symbols and other IEEE-like pin function graphics in our symbols. That's my suggestion. |
@evanshultz the main benefit is not to allow power symbols to be grouped, but to allow multi-part symbols to be drawn without repetition of power pins. If you are splitting single-unit devices into multiple symbols just to place the power pins, why not do that for all symbols e.g. microcontrollers etc? I am going to push the KLC changes now, I've made some slight tweaks to other items you have raised above (thanks!) These larger issues we can discuss going forward for 2.1... |
@poeschlr @jkriege2 @SchrodingersGat Can this issue be closed? Continuing KLC concerns can be covered elsewhere (like here), right? |
Thanks everyone for your great help :) |
Nominally we suggest PWR pins are located at the top of a symbol, and GND pins at the bottom. However this is not stated in the KLC rules.
I suggest that rule 3.5 be updated as follows:
###Old Rule 3.5
Whenever possible, inputs are on the left and outputs are on the right.
###New Rule 3.5
The text was updated successfully, but these errors were encountered: