-
Notifications
You must be signed in to change notification settings - Fork 950
Adding scripted generic connector symbols as discussed in issue #1451 #1561
Adding scripted generic connector symbols as discussed in issue #1451 #1561
Conversation
…laced with conn_02x*_counter_clockwise connectors. SIL connectors are duplicates of conn_01x* connectors)
Travis complains about missing datasheet links and about my footprint filters for the dual row connectors. |
When do you have Male and female connectors connected on the same board? |
Regarding footprint filters: |
…ill background flags from single row connectors.
Travis now complains about the 1 pin male connector because it believes the artwork used for the male symbol is the outline of the symbol. |
This look very nice! If there's a script, should it be imported somewhere once we've finalized the design? I also don't like this symbol change. Male and female that mate are on different boards, and in the case where they aren't why do we care if the symbols can snuggle together so much? I vote to go back. I also think we go for |
I will add it to the other generator scripts that live in the kicad-library-utils repo. |
The question here is having male and female symbols that mate together. Having male and female together is common and having, but having a mating pair of male/female connectors on the same board is odd. |
It looks like the naming scheme for dual row connectors is not as consistent as i thought. New filter options.
In my new naming convention i will fix one way to name connector footprints. For single row connectors i might use
Footprint filter feature: #1170 |
I have to admit, it was not the best idea I've ever had, but that's exactly what I did :D |
I'm not gonna hack my way around travis. Travis is correct in this case because the symbols without outline violate KLC. (If anything it should complain about all female and male symbols.) |
@jkriege2 or @evanshultz i think this is now ready for review. Edit: The footprint filters are tested in a nightly from 4 days ago. They work with the current naming scheme for connectors. |
Oh okay, that's my fault then, sorry. I've known about the KLC requiring an outline width of 10 mils but didn't realize that the actual presence of an outline body is required |
For symbols like this i think it is required (by KLC). Exceptions are symbols like a diode or a single transistor. (At least this is my interpretation.) |
Thanks for the clarification :) |
If we were to merge, does the FPfilter work in 4.0.7? It doesn't work in 4.0.6, but I assume your comment about testing in nightly above is to confirm 4.0.7 will be OK. Also, right now we have lots of compatible parts in BTW, while there's a huge number of symbols they look very nice and I don't see any other problems stopping them from being merged. Thank you! |
The filter does not work in any stable release. For now i will add the old filters back to the symbols where appropriate. This way the pin headers are filtered in all versions of kicad, but all other connectors only in nightly. |
@evanshultz Footprint filters are fixed now. |
@poeschlr Great! Looks good and works in 4.0.6, if that matters. |
Thanks for all the input i got. And thanks for the quick merge. This was truly a team effort. |
Since this question spans multiple footprint repos and is related to this topic, perhaps we continue the discussion here. How to name the footprint libs? Something like this:
I dislike having a generic Connector.pretty repo, since it will likely turn into a wasteland, but there are so many connector types it may be the best way to go. We could use This is just a start, and having a table to better flesh out the purpose of each library would be required. But we have to get the ball rolling somehow. If you don't object this start, I'll create a new issue (maybe in Connectorrs.pretty repo) to hash this out. |
I thought about the same thing today. I think we should move this to a issue though. Otherwise it will be missed by someone. (Should be a new RFC issue i think) Short note: I like Connector_Network more than Connector_Ethernet I would also keep the name Connectors instead of Connector. (Otherwise all current repos need to be renamed again.) |
Thanks for the new connectors! Great work! |
This adds the script generated connector symbols as discussed in #1451
All symbols are added from 1 to 40 pins per row except for screw terminals. These are added from 1 to 20 pins.