Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant kernel arguments #200

Closed
wants to merge 1 commit into from
Closed

Remove redundant kernel arguments #200

wants to merge 1 commit into from

Conversation

TommyTran732
Copy link

Closes #199

@adrelanos
Copy link
Member

Could be out-commented instead of deleted please?

@adrelanos adrelanos self-requested a review February 15, 2024 07:55
@raja-grewal raja-grewal mentioned this pull request Mar 12, 2024
Open
adrelanos
adrelanos requested changes May 10, 2024
View reviewed changes
Copy link
Member

@adrelanos adrelanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems stalled as per discussion in #199

@TommyTran732
Copy link
Author

I am just gonna close this for now until we reach consensus in #199, I can make a new PR later.

@TommyTran732 TommyTran732 deleted the remove-redundant-kernel-args branch May 22, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrelanos adrelanos adrelanos requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redundant kernel args
2 participants
@TommyTran732 @adrelanos