Skip to content

Conversation

n7studios
Copy link
Contributor

Summary

Adds the following API functions to provide API coverage for Webhooks

  • get_webhooks()
  • create_webhook()
  • destroy_webhook()

Testing

  • testGetWebhooks(): Test that listing webhooks works.
  • testCreateAndDestroyWebhook(): Test that creating and destroying a webhook works.
  • testCreateAndDestroyWebhookWithEventParameter(): Test that creating and destroying a webhook with an event parameter works
  • testCreateWebhookWithInvalidEvent(): Test that creating a webhook with an invalid event throws an InvalidArgumentException
  • testDestroyWebhookWithInvalidRuleID(): Test that destroying a webhook that doesn't exist throws a ClientException

Checklist

@n7studios n7studios self-assigned this Mar 13, 2023
@n7studios n7studios added this to the 1.0.0 milestone Mar 13, 2023
@n7studios n7studios changed the base branch from master to 1.0-beta March 13, 2023 17:39
@n7studios n7studios requested review from a team, noelherrick and jenessawhite and removed request for a team March 13, 2023 17:39
@n7studios n7studios marked this pull request as ready for review March 13, 2023 17:40
# Conflicts:
#	src/ConvertKit_API.php
#	tests/ConvertKitAPITest.php
@n7studios n7studios merged commit 3b8a826 into 1.0-beta Mar 14, 2023
@n7studios n7studios deleted the webhook-functions branch March 23, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants