enable editor changes in sketch mode, refactor some of the code manager #2287
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Irev-Dev
force-pushed
the
kurt-revert-revert
branch
from
d27c80f
to
a7b6802
Compare
|
my bet is fefbd75 will break a bunch of the onboarding and a few other things, but I think that's just because |
Irev-Dev
changed the title
| @@ -12,7 +12,7 @@ export default function FutureWork() { | |||
|
|
|||
| useEffect(() => { | |||
| // We do want to update both the state and editor here. | |||
| codeManager.updateCodeStateEditor(bracket) | |||
There was a problem hiding this comment.
wait so im confused you dont want to update the state for these? if that state is now never used we can nukke it
There was a problem hiding this comment.
well this isn't my code so not super sure, but there were onboarding tests that failed before this change that are now passing so I think this is what we want.
There was a problem hiding this comment.
updateCodeEditor is still used in a couple of more places so I'll keep it for now.
Irev-Dev
force-pushed
the
kurt-revert-revert
branch
from
7e0e5be
to
7a8a4db
Compare
Irev-Dev
force-pushed
the
kurt-revert-revert
branch
from
1dd2519
to
0029947
Compare
Irev-Dev
force-pushed
the
kurt-revert-revert
branch
from
9ee3546
to
131746a
Compare
…ges to t… (#2286)"
This reverts commit e7ab645.
implementing #2283 again, but just making sure playwright passes before merging.
Will also revolve #1558
Screenshare.-.2024-05-03.9_14_00.PM.mp4