feat(example): PET MIP with window/level adjustment #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@floryst @jun-sironamedical Please review. |
|
@jadh4v looks good to me, seems pretty straight forward. Might have questions when I try to implement though, but this PR looks good. |
danyim
reviewed
Aug 1, 2024
| @@ -349,6 +354,20 @@ function Example(props) { | |||
| setValue={setColorPreset} | |||
| style={{ top: '10px', left: '405px' }} | |||
| /> | |||
| <Slider | |||
| label='PET Level' | |||
| max={34611} | |||
There was a problem hiding this comment.
Are these max constants based on the underlying data's range?
There was a problem hiding this comment.
Yes. Ideally, this should be set to max scalar range. Or some heuristic value based on it.
|
LGTM after Daniel's comment is addressed! |
|
🎉 This PR is included in version 2.0.0-beta.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sliders and
VolumeRepresentationproperty values for adjusting the data range applicable for the grayscale colormap.This effectively has the resulting behavior of Window/Level adjustment.
I have verified that, in the fragment shader, the color transfer function is indeed applied after the raw voxel values are projected to the viewport. Therefore, using
colorDataRangeas a way to apply window/level adjustment for a MIP view is appropriate.pet-ct-WL.mp4