Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track time execution of all tests assigned to CI node in Queue Mode even when they did not run due syntax error or being pending/empty in test run #71

Merged
merged 5 commits into from
Oct 26, 2018
Merged

Track time execution of all tests assigned to CI node in Queue Mode even when they did not run due syntax error or being pending/empty in test run #71

merged 5 commits into from
Oct 26, 2018

Conversation

ArturT
Copy link
Member

@ArturT ArturT commented Oct 21, 2018 •
edited
Loading

This fix allows recording default timing 0.1s for test files like:

Queue Mode for RSpec

  • test file is empty
  • test file has only pending tests
  • test file has a syntax error

Queue Mode for Minitest

  • test file is empty
  • test file has only pending tests
  • test file has a syntax error (this breaks the runtime, the Knapsack Pro API will run the same set of tests when you retry failed CI node)

@ArturT
Track all tests assigned to CI node even when they did not run due sy…
053f951 
…ntax error or being pending in test run
@ArturT
Set a default time for test file in case when the test file will not be
11b573d 
run due syntax error or being pending. The time is required by Knapsack
Pro API.
@ArturT
Record timing of empty or pending tests (also in case of RSpec we rec…
1d7d0c8 
…ord the tests with syntax error) in Queue Mode RSpec/Minitest.
@ArturT
Remove puts
02eafc2
@ArturT ArturT mentioned this pull request Jun 13, 2023
Open
@ArturT ArturT changed the title Track all tests assigned to CI node even when they did not run due syntax error or being pending in test run Track all tests assigned to CI node in Queue Mode even when they did not run due syntax error or being pending in test run Oct 26, 2018
@ArturT ArturT changed the title Track all tests assigned to CI node in Queue Mode even when they did not run due syntax error or being pending in test run Track all tests assigned to CI node in Queue Mode even when they did not run due syntax error or being pending/empty in test run Oct 26, 2018
@ArturT ArturT changed the title Track all tests assigned to CI node in Queue Mode even when they did not run due syntax error or being pending/empty in test run Track time execution of all tests assigned to CI node in Queue Mode even when they did not run due syntax error or being pending/empty in test run Oct 26, 2018
@ArturT ArturT merged commit 93ab826 into master Oct 26, 2018
@ArturT ArturT deleted the record-tests-that-did-not-execute branch October 26, 2018 11:58
ArturT added a commit to KnapsackPro/knapsack-pro-jest that referenced this pull request Jan 10, 2019
@ArturT
Use default time 0.1s when test file time equal zero. This way we mee…
2f98261 
…t Knapsack Pro API requirement to post only time execution greater than zero.

Related:
* KnapsackPro/knapsack_pro-ruby#71
* https://github.com/KnapsackPro/knapsack-pro-core-js/issues/3
@ArturT ArturT mentioned this pull request May 2, 2019
Merged
@ArturT ArturT mentioned this pull request Apr 9, 2021
Merged
@ArturT ArturT mentioned this pull request Jul 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ArturT