Skip to content

Track all test files assigned to a CI node in Regular Mode including pending test files in order to retry proper set of tests on the retried CI node#152

Merged
ArturT merged 19 commits intomasterfrom
track-all-test-files-in-regular-mode
Jul 29, 2021
Merged

Track all test files assigned to a CI node in Regular Mode including pending test files in order to retry proper set of tests on the retried CI node#152
ArturT merged 19 commits intomasterfrom
track-all-test-files-in-regular-mode

Conversation

@ArturT
Copy link
Copy Markdown
Member

@ArturT ArturT commented Jul 23, 2021

bug

  • When you use Regular Mode and RSpec and you run first CI build then Knapsack Pro API returns a list of test files assigned to the CI node. If the test files have a pending test file then RSpec won't run it. This causes not measuring time execution for the pending test file. Because of that list of test files that is saved to Knapsack Pro API does not contain the pending test file.
  • Problem happens when you retry CI node and you expect the same set of test files will be assigned to the CI node. But there is missing pending spec file which was not recorded during the first CI build run.

fix

Track all test files assigned to the CI node and save them to Knapsack Pro API after tests are executed. Thanks to that pending test file will have default 0 seconds time execution. When you retry CI node then the pending test file will be assigned to the retired CI node properly.

Improvement was made for Regular Mode for all test runners (RSpec, Cucumber, Minitest, ...etc)

related old PR for a similar change in Queue Mode

#71

@ArturT ArturT changed the title Track all test files assigned to CI node in Regular Mode including pending test files in order to retry proper set of tests on retried CI build Track all test files assigned to a CI node in Regular Mode including pending test files in order to retry proper set of tests on the retried CI node Jul 23, 2021
@ArturT ArturT requested a review from shadre July 29, 2021 12:43
Copy link
Copy Markdown
Member

@shadre shadre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👍

@ArturT ArturT merged commit 3aa4192 into master Jul 29, 2021
@ArturT ArturT deleted the track-all-test-files-in-regular-mode branch July 29, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants