-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map cell_shape in big trait table #4
Comments
Shape itself maps to PATO:0000052. This is what I found from OLS. @cmungall , manual curation for these too? or OGER?
|
How formal do we want to be about defining
Do we want to add a class
Also, how far much detail do we want in defining
If we wanted, we could formally define
This would allow for more general queries that use (or don't use) certain materials as during growth. |
Is this done?
…On Thu, Feb 18, 2021, 10:35 marcin joachimiak ***@***.***> wrote:
Closed #4 <#4>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMMOOFX7VKYYBFNDAROLDS7VMY5ANCNFSM4U664HWA>
.
|
Nodes for shapes with a prefix of 'Shape:' were created. The CURIEs listed above were neither confirmed nor rejected. |
We'll still need direction on how to address this. Is the temporary 'Shape:' prefix okay or do we hard-code the above CURIEs corresponding to the various shapes? |
Let's keep this open while we decide our long term strategy:
However, for now, it is OK to just do something like what we are doing However, can you make the CURIEs like this:
To correspond to our schema (#13 ) |
Split from #2
1 spirochete
1 ring
1 triangular
1 cell_shape
2 tailed
3 branced
3 spindle
3 star
4 irregular
5 flask
7 square
11 disc
12 fusiform
60 pleomorphic
289 vibrio
328 filament
400 spiral
402 coccobacillus
1563 coccus
3794 NA
4035 bacillus
I think the majority should map to PATO. We may want to consider making OBA terms for some
The text was updated successfully, but these errors were encountered: