Fix github actions #739
Open
Fix github actions #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update rector/rector to fix error when running ``vendor/bin/rector process --dry-run --ansi`` PHP Fatal error: Uncaught _PHPStan_9a6ded56a\Nette\InvalidArgumentException: Missing parameter 'deprecationRulesInstalled'.
Remove missing NetteSetList [ERROR] Class "Rector\Nette\Set\NetteSetList" not found
|
@TomasVotruba @VincentLanglet Please tell me what is expected for the rector check. Do you wants to update the code according to the diff provided by the command: I can remove the dry-run parameter but I'm not sure that it's what you wants. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix large part of the github actions. We still have an issue with rector because we use the dry-run parameter and there is some diff.
In that case, from the following commit (rectorphp/rector#805), rector returns a Error: Process completed with exit code 2.