Skip to content

Add comment on AbstractApi::$perPage() #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2021
Merged

Add comment on AbstractApi::$perPage() #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Github/Api/AbstractApi.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ abstract class AbstractApi
private $client;

/**
* The per page parameter.
* The per page parameter. It is used by the ResultPager.
*
* @var int|null
*/
Expand Down
20 changes: 0 additions & 20 deletions test/Github/Tests/Integration/ResultPagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,24 +9,6 @@
*/
class ResultPagerTest extends TestCase
{
/**
* @test
*/
public function shouldPaginateGetRequests()
{
$repositoriesApi = $this->client->api('user');
$repositoriesApi->setPerPage(10);

$pager = $this->createPager();

$repositories = $pager->fetch($repositoriesApi, 'repositories', ['KnpLabs']);
$this->assertCount(10, $repositories);

$repositoriesApi->setPerPage(20);
$repositories = $pager->fetch($repositoriesApi, 'repositories', ['KnpLabs']);
$this->assertCount(20, $repositories);
}

/**
* @test
*
Expand All @@ -43,10 +25,8 @@ public function shouldPaginateGetRequests()
public function shouldGetAllResultsFromSearchApi()
{
$searchApi = $this->client->search();
$searchApi->setPerPage(10);

$pager = $this->createPager();

$users = $pager->fetch($searchApi, 'users', ['location:Kyiv']);
$this->assertCount(10, $users);
}
Expand Down