Skip to content

Remove constructor constraint from interface declaration #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Jul 31, 2014
Merged

Remove constructor constraint from interface declaration #165

merged 1 commit into from Jul 31, 2014

Conversation

fabre-thibaud
Copy link

Fix #164

@weaverryan
Copy link

+1 on this fix!

And removing this doesn't hurt anything - it's obviously not used anywhere (e.g. it's not like we're type-hinting an ApiInterface argument and then calling __construct on it. The only usage is when we're constructing the Api\* classes in Client, and these are all concrete classes that we're instantiating anyways, where we definitely know what the constructor looks like (e.g. new Api\Organization($this);).

👍

Nek- added a commit that referenced this pull request Jul 31, 2014
Remove constructor constraint from interface declaration
@Nek- Nek- merged commit e0745bf into KnpLabs:master Jul 31, 2014
@Nek-
Copy link
Contributor

Nek- commented Jul 31, 2014

Thank you @aztech-dev

@fabre-thibaud fabre-thibaud deleted the issue-164 branch July 31, 2014 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove constructor declaration from ApiInterface
3 participants