Add ability to check that a file exists in repo branch/commit #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2014 14:22
Using only HEAD method to avoid downloading file contents when the file does exist
| @@ -172,7 +194,7 @@ protected function delete($path, array $parameters = array(), $requestHeaders = | |||
| /** | |||
| * Create a JSON encoded version of an array of parameters. | |||
| * | |||
| * @param array $parameters Request parameters | |||
| * @param array $parameters Request parameters | |||
|
Thank you ! The idea is pretty :) . Can you add a part of doc for it ? |
|
Erf, sorry, comes from my autoformat settings... Gonna fix that & add the doc |
|
All right, doc is done for the Contents API (except the archive endpoint which I never user). Let me know if there are changes to be made. |
| } | ||
| } | ||
| catch (TwoFactorAuthenticationRequiredException $ex) { | ||
| throw $ex; |
There was a problem hiding this comment.
should be 1 line above with } catch, same for others
|
@aztech-dev perfect! |
cursedcoder
added a commit
that referenced
this pull request
Aug 1, 2014
Add ability to check that a file exists in repo branch/commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Contents API requires to download the file (even with the "show" method, file content is returned up to 1Mb in size) just to check if it exists remotely.
Proposed changes adds a head(...) helper method to AbstractApi and leverages it to make a HEAD call to the "Get contents" endpoint of the API instead of a GET to avoid downloading file content.