Add ability to get user by ID #372
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bocharsky-bw what is the difference with the documented way to get a user ? https://developer.github.com/v3/users/#get-a-single-user (which is already implemented) |
| return $this->get('users?since=' . rawurldecode($id)); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
there are loads of things like this everywhere though, that we don't include, like repos by id
|
Ah, tests failed... I should use another method name. @Nek- The OAuth library which I used in my project works with IDs (GitHub ID, Facebook ID, etc.). So I need a way to fetch / update user information based on a user's GitHub ID. |
|
Closing this because of inactivity. |
Merged
acrobat
pushed a commit
that referenced
this pull request
Jul 4, 2020
This PR was squashed before being merged into the 2.x branch. Discussion ---------- Revamp of #372 which was abandonned, and following the example of #579 As of 2020, gettting data by ID is still undocumented. I contacted Github support to make sure it could be relied on. > <img width="691" alt="Screen Shot 2020-07-02 at 10 12 15 PM" src="https://user-images.githubusercontent.com/664857/86434021-2d17f700-bcb1-11ea-9f19-2008ce47412d.png"> ------ I have been working with an old application and I have to deal with actions made by user that have changed their login since. The old login are now used by totally different people, which can be problematic. Commits ------- 5ed46cc Update User.php 5703492 Add unit test 62b43ab Documentation cdaad05 Remove usage of rawurlencode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on http://stackoverflow.com/questions/11976393/get-github-username-by-id