Fix return type

[patrik-csak]

\Github\Api\Repository\Contents::archive() claims to return an array, but in my testing it returns a string.

echo gettype(
    (new \Github\Client())->api('repo')
        ->contents()
        ->archive('twbs', 'bootstrap', 'tarball', 'tags/v4.0.0')
); // `string`

I spun up a small test project to test it. Here's the gist.

[acrobat]

In the api docs they state they do (return) a redirect

This method will return a 302 to a URL to download a tarball or zipball archive for a repository. Please make sure your HTTP framework is configured to follow redirects or you will need to use the Location header to make a second GET request.

What's the actual result in your example? The url of the archive or the content of the archive?

[patrik-csak]

The result is the contents of the archive.

[acrobat]

@ptrkcsk ok, thanks for the feedback and the fix!

[patrik-csak]

Happy to help!