Skip to content

Mark some classes as final #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Mark some classes as final #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/Github/HttpClient/Message/ResponseMediator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
use Github\Exception\ApiLimitExceedException;
use Psr\Http\Message\ResponseInterface;

/**
* @final since 2.19
*/
class ResponseMediator
{
/**
Expand Down
1 change: 1 addition & 0 deletions lib/Github/HttpClient/Plugin/Authentication.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* Add authentication to the request.
*
* @author Tobias Nyholm <tobias.nyholm@gmail.com>
* @final since 2.19
*/
class Authentication implements Plugin
{
Expand Down
1 change: 1 addition & 0 deletions lib/Github/HttpClient/Plugin/GithubExceptionThrower.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
/**
* @author Joseph Bielawski <stloyd@gmail.com>
* @author Tobias Nyholm <tobias.nyholm@gmail.com>
* @final since 2.19
*/
class GithubExceptionThrower implements Plugin
{
Expand Down
1 change: 1 addition & 0 deletions lib/Github/HttpClient/Plugin/History.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
* A plugin to remember the last response.
*
* @author Tobias Nyholm <tobias.nyholm@gmail.com>
* @final since 2.19
*/
class History implements Journal
{
Expand Down
1 change: 1 addition & 0 deletions lib/Github/HttpClient/Plugin/PathPrepend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
* Prepend the URI with a string.
*
* @author Tobias Nyholm <tobias.nyholm@gmail.com>
* @final since 2.19
*/
class PathPrepend implements Plugin
{
Expand Down