-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deck always update rate-limiter plugin config even no changes #1251
Comments
I've also run into this with Kong 3.6 and deck 1.26.0. |
Prashansa-K
added a commit
to Kong/go-kong
that referenced
this issue
Aug 5, 2024
As of now, deprecated fields are renamed to shorthand_fields in all schemas, as per the conventions. Till now, we do not fill any values for these fields while attempting to fill config records for plugins. This creates a visualisation problem in decK. Everytime, a deck diff or deck sync command is issued, it shows that the deprecated field values are changed and need to be updated, thus running an unnecessary update process each time and also confusing end users. Check #1251: Kong/deck#1251 for clarity. This fix attempts to fill defaults for the shorthand_fields, retaining their values, if passed. Also, since shorthand_fields take priority over normal/nested fields in the gateway, if any changes are detected in shorthand_fields, it is backfilled to nested fields as well.
pmalek
pushed a commit
to Kong/go-kong
that referenced
this issue
Aug 5, 2024
As of now, deprecated fields are renamed to shorthand_fields in all schemas, as per the conventions. Till now, we do not fill any values for these fields while attempting to fill config records for plugins. This creates a visualisation problem in decK. Everytime, a deck diff or deck sync command is issued, it shows that the deprecated field values are changed and need to be updated, thus running an unnecessary update process each time and also confusing end users. Check #1251: Kong/deck#1251 for clarity. This fix attempts to fill defaults for the shorthand_fields, retaining their values, if passed. Also, since shorthand_fields take priority over normal/nested fields in the gateway, if any changes are detected in shorthand_fields, it is backfilled to nested fields as well.
Prashansa-K
added a commit
to Kong/go-kong
that referenced
this issue
Aug 5, 2024
* fix: fill config values and defaults in shorthand fields As of now, deprecated fields are renamed to shorthand_fields in all schemas, as per the conventions. Till now, we do not fill any values for these fields while attempting to fill config records for plugins. This creates a visualisation problem in decK. Everytime, a deck diff or deck sync command is issued, it shows that the deprecated field values are changed and need to be updated, thus running an unnecessary update process each time and also confusing end users. Check #1251: Kong/deck#1251 for clarity. This fix attempts to fill defaults for the shorthand_fields, retaining their values, if passed. Also, since shorthand_fields take priority over normal/nested fields in the gateway, if any changes are detected in shorthand_fields, it is backfilled to nested fields as well. * test: unit test added for shorthand_fields filling * chore: godoc for new functions added, comments added for clarification * chore: typo correction and preallocation of slice for backward path translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kong gateway diff/sync report need to update every rate-limiter plugin config every sync/diff applied
There seems to be undocumented redis_* keys which cause the issue. Either those keys should not be checked or those should be added to render output.
Also sync with merged fails when unused config keys are not set.
Repro steps
Kong 3.6.1.1, Deck 1.25 Linux
Create simple service with route and rate-limiter plugin
render config and sync with Kong
Then run validate or sync again
Every time deck indicate needs to update the rate-limit config
Workaround is possible by adding dummy redis_* keys into into declarative rate-limiter plugin config
The text was updated successfully, but these errors were encountered: