AutoFocus URL bar when onboarding/switching/opening a request#4338
Merged
dimitropoulos merged 2 commits intoKong:developfrom Jan 5, 2022
Merged
AutoFocus URL bar when onboarding/switching/opening a request#4338dimitropoulos merged 2 commits intoKong:developfrom
dimitropoulos merged 2 commits intoKong:developfrom
Conversation
I tried and tried to make it work before, but I kept getting errors (because you have to use the unsafe legacy lifecycle methods) including `unstable_flushDiscreteUpdates: Cannot flush updates when React is already Rendering` and `RequestPane.getSnapshotBeforeUpdate(): A snapshot value (or null) must be returned.` It's already stateless, so a good candidate to switch now since it blocked me.
dimitropoulos
force-pushed
the
feat/focus-url-bar
branch
from
65765e9 to
4a4c018
Compare
gatzjames
approved these changes
Jan 5, 2022
Contributor
gatzjames
left a comment
gatzjames
left a comment
There was a problem hiding this comment.
LGTM! Great improvement!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2022-01-04_13-43-25.mp4
There are three behaviors this PR changes:
closes INS-1308
changelog(Improvements): URL bar will now autofocus when interacting with new requests or switching between requests